Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces comprehensive support for basketball within the management application. Key changes include the addition of sport-specific routing, updated data types to include sportType, and the creation of new components for basketball timelines, event records, and administrative sheets (score, foul, and substitution). Feedback focuses on refining the logic for cumulative score displays in the timeline, improving null safety when accessing team data, removing unused props, and ensuring consistent use of the design system for styling. Additionally, there are suggestions to refactor redundant logic in player selection hooks for better maintainability.
seongminn
approved these changes
Apr 14, 2026
sungwonnoh
added a commit
that referenced
this pull request
Apr 15, 2026
* feat: sportType 추가 * feat: ui에 sportType 추가 * style: 종목선택 ui변경 * feat: 리그생성시 해당 종목에 속하는 팀만 보이도록 * style: 대회관리에서 ui깨짐 문제 해결 * fix: 현재 폼의 sportType을 제출하도록 수정 * feat(manager): 종목별 라우팅 분리 (#491) * feat: 종목 구분에 따른 라우팅 변경 * feat: 농구 타임라인 파일생성 * chore: 상태변경 sheet 내용 삭제 * fix: 빌드에러 수정
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🌍 이슈 번호
✅ 작업 내용
/leagues/{id}/{gameId}->/leagues/{id}/soccer/{gameId},/leagues/{id}/basketball/{gameId}📝 참고 자료
♾️ 기타