Skip to content

feat(manager): 종목별 라우팅 분리#491

Merged
sungwonnoh merged 4 commits intoadd-sportTypefrom
feat/sperate-sport
Apr 15, 2026
Merged

feat(manager): 종목별 라우팅 분리#491
sungwonnoh merged 4 commits intoadd-sportTypefrom
feat/sperate-sport

Conversation

@sungwonnoh
Copy link
Copy Markdown
Contributor

🌍 이슈 번호

  • 이슈 번호

✅ 작업 내용

  • 축구와 농구의 게임 진행 화면이 다르고, 앞으로도 종목별 분기가 계속 늘어날 것으로 예상되어 URL 레벨에서 종목을 분리했어요
  • 라우팅 구조 변경
    • 예) /leagues/{id}/{gameId} -> /leagues/{id}/soccer/{gameId}, /leagues/{id}/basketball/{gameId}
    • /leagues/{id} 하위로 종목 분기
  • 농구 전용 타임라인 파일 생성
    • basketball-timeline.tsx — 쿼터 탭 + 탭별 점수(쿼터 스냅샷)
    • basketball-event-record.tsx — 농구 전용 이벤트 표시
    • basketball-bottom-button.tsx — 파울 버튼 포함
    • sheets/ — BasketballAddScoreSheet, BasketballStatusChangeSheet, BasketballFoulSheet, BasketballSubstituteSheet

📝 참고 자료

  • 작업한 내용에 대한 부연 설명

♾️ 기타

  • 화면 라우팅에 대해서만 작업했습니다! 농구 관련 ui나 API는 추가로 작업예정입니다

@sungwonnoh sungwonnoh self-assigned this Apr 14, 2026
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
manager Ready Ready Preview, Comment Apr 14, 2026 1:28pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
spectator Skipped Skipped Apr 14, 2026 1:28pm

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces comprehensive support for basketball within the management application. Key changes include the addition of sport-specific routing, updated data types to include sportType, and the creation of new components for basketball timelines, event records, and administrative sheets (score, foul, and substitution). Feedback focuses on refining the logic for cumulative score displays in the timeline, improving null safety when accessing team data, removing unused props, and ensuring consistent use of the design system for styling. Additionally, there are suggestions to refactor redundant logic in player selection hooks for better maintainability.

@vercel vercel bot temporarily deployed to Preview – spectator April 14, 2026 13:26 Inactive
@sungwonnoh sungwonnoh changed the base branch from dev to add-sportType April 14, 2026 13:28
@sungwonnoh sungwonnoh merged commit f1331df into add-sportType Apr 15, 2026
3 checks passed
sungwonnoh added a commit that referenced this pull request Apr 15, 2026
* feat: sportType 추가

* feat: ui에 sportType 추가

* style: 종목선택 ui변경

* feat: 리그생성시 해당 종목에 속하는 팀만 보이도록

* style: 대회관리에서 ui깨짐 문제 해결

* fix: 현재 폼의 sportType을 제출하도록 수정

* feat(manager): 종목별 라우팅 분리 (#491)

* feat: 종목 구분에 따른 라우팅 변경

* feat: 농구 타임라인 파일생성

* chore: 상태변경 sheet 내용 삭제

* fix: 빌드에러 수정
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants