Fix getUser() 404 for bot users in PR reviews#2207
Open
Haarolean wants to merge 1 commit intohub4j:mainfrom
Open
Fix getUser() 404 for bot users in PR reviews#2207Haarolean wants to merge 1 commit intohub4j:mainfrom
getUser() 404 for bot users in PR reviews#2207Haarolean wants to merge 1 commit intohub4j:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2207 +/- ##
============================================
- Coverage 85.03% 85.03% -0.01%
+ Complexity 2499 2498 -1
============================================
Files 237 237
Lines 7366 7364 -2
Branches 388 388
============================================
- Hits 6264 6262 -2
Misses 871 871
Partials 231 231 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed
getUser()404 for bot users in PR reviews.Use
intern()instead ofgetUser()to avoid API calls to /users/{login}, which returns 404 for bot/app users. This matches the pattern already used byGHIssue,GHRepositoryDiscussion, and others.Verified locally consuming a related webhook.
original stacktrace:
Before submitting a PR:
@linkJavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .mvn -D enable-ci clean install site "-Dsurefire.argLine=--add-opens java.base/java.net=ALL-UNNAMED"locally. If this command doesn't succeed, your change will not pass CI.main. You will create your PR from that branch.When creating a PR: