Switch to the new operations for obtaining OS handles#348
Switch to the new operations for obtaining OS handles#348jeltsch wants to merge 1 commit intohaskell:masterfrom
Conversation
|
Note that the tests necessarily fail with currently released GHC versions, as they require the new module |
|
I removed the draft status of this pull request for it not to get lost. |
|
Thank you very much for this contribution. I will try to clarify exactly who the maintainers of Perhaps @jeltsch, you'd like to become a maintainer of |
|
Thanks a lot for moving this forward. As for myself, I don’t see myself as a future maintainer of |
|
@bgamari, do you have the capacity to take on the review of this? |
There is an effort to move some GHC-specific modules out of
base. Candidates for such moving areGHC.IO.Handle.TypesandGHC.IO.Handle.Internals. These modules are often used for obtaining operating-system handles (file descriptors, Windows handles) from Haskell handles. Such uses are also present in theprocesspackage.There is a proposal to add dedicated operations for operating-system handle acquisition to
base. A corresponding draft implementation can be found in GHC merge request !14732. The present pull request forprocesschanges the package to use those new operations.Note that this pull request changes the behavior of
System.Process.Common.mbFdin two ways:withHandlefamily of operations fromGHC.IO.Handle.Internalsbut may not be what is desired.