FE-738: Petri semantic lanes — two-lane subnet, compiler split, engine factory by kostandinang · Pull Request #148 · hashintel/brunch

kostandinang · 2026-05-21T18:34:49Z

Summary

Phase 1 of the petri orchestrator arc (umbrella H-6476). First frontier where petri models a distinction proc cannot express topologically: mechanical completion ≠ semantic completion. Stacks on FE-730 (#143).

Changes

Two-lane slice subnet — mechanical (evaluate → write-tests → write-code → run-tests) and semantic (assess-semantic → semantic-satisfied), joined by a completion gate so PlanDoneAccepted is unreachable without both.
TransitionContract metadata on every transition (kind, lane, actor, guard).
§7 event vocabulary — transition_fired, net_halted, net_deadlocked emitted by the interpreter.
Compiler split — compileTopology(plan, policy) → NetBlueprint (pure data) + wireHandlers(blueprint, input, ctx) → PetriNet (closures). Adapter tests run on topology alone.
Engine factory — createOrchestrator(policy) replaces duplicated PetriOrchestrator / ProceduralOrchestrator (~120 LOC).
HandlerDescriptor discriminated union — declarative branch outputs per transition (onPass / onFail / onTrue / onFalse / onSatisfied / onRejected).
Semantic rework budget — semantic-budget place + reworkCount token prevents infinite rework loops (review finding Bump picomatch #8). Adds RunPolicy.maxSemanticReworks.

Verification

npm run verify clean — 1378 tests across 120 files.

Acceptance (per `memory/PLAN.md`)

(1)–(4), (6) met. (5) stale-graph routing to reconciliation deferred to follow-up slice.

PR Summary

Medium Risk
Medium risk because it changes orchestrator execution topology and introduces new required action (assess-semantic) plus new halting paths (semantic rework exhaustion) that can affect completion behavior and event emission.

Overview
Implements a two-lane slice subnet by adding assess-semantic and gating return-done on semantic-satisfied, with a new semantic-budget/reworkCount mechanism and RunPolicy.maxSemanticReworks to halt slices that loop on semantic rejection.

Refactors compilation into a pure topology pass (compileTopology → NetBlueprint) plus a wiring pass (wireHandlers) driven by a new declarative HandlerDescriptor, and replaces the separate proc/petri engine classes with createOrchestrator('serial').

Extends the Petri interpreter with TransitionContract metadata on transitions and an optional §7-style event sink emitting transition_fired/net_halted/net_deadlocked; contract and adapter tests are updated/expanded accordingly, and planning docs are updated (including removal of memory/CARDS.md).

^{Reviewed by Cursor Bugbot for commit 1747538. Bugbot is set up for automated code reviews on this repo. Configure here.}

cursor · 2026-05-22T12:40:33Z

+        const hasTokens = [...this.places.values()].some((tokens) => tokens.length > 0);
+        if (hasTokens) {
+          eventSink?.emit({ kind: 'net_deadlocked', ts: new Date().toISOString() });
+        }


False net_deadlocked on success

Medium Severity

When no transition is enabled, the interpreter emits net_deadlocked whenever any place still holds tokens. After a successful slice, idle test-agent and code-agent tokens remain, so completed runs can record a deadlock event alongside normal transition_fired events.

^{Reviewed by Cursor Bugbot for commit 8e56a7c. Configure here.}

augmentcode · 2026-05-22T12:42:03Z

🤖 Augment PR Summary

Summary: This PR evolves the Petri-net orchestrator by introducing distinct mechanical vs semantic completion lanes, and refactors compilation/execution so the net shape is testable as pure data.

Changes:

Introduces a two-lane slice subnet (mechanical TDD loop + semantic assessment) with a completion gate so slices can’t finish without semantic satisfaction.
Adds TransitionContract metadata to transitions (kind/lane/actor/guard) to classify execution without parsing IDs.
Splits the compiler into compileTopology(plan, policy) → NetBlueprint (pure topology) and wireHandlers(...) (runtime closures), plus a convenience compilePlan wrapper.
Consolidates engine entrypoints into createOrchestrator(firingPolicy), removing duplicated Petri/procedural engine classes.
Adds semantic rework budgeting via a semantic-budget token (reworkCount) and RunPolicy.maxSemanticReworks to prevent infinite semantic-rejection loops.
Defines §7-style interpreter events (transition_fired, net_halted, net_deadlocked) and updates adapter tests to assert event emission.
Updates engine contract tests to cover semantic-gate rework and semantic budget exhaustion scenarios.

Technical Notes: Topology-only adapter tests no longer require action handlers/test runners, and runtime wiring now interprets declarative handler descriptors from the blueprint.

_{🤖 Was this summary useful? React with 👍 or 👎}

augmentcode

Review completed. 2 suggestions posted.

Comment augment review to trigger a new review at any time.

augmentcode · 2026-05-22T12:42:04Z

+          const budgetToken = consumed[1]!;
+          const reworkCount = budgetToken.reworkCount ?? 0;
+
+          const reportId = await actions[actionKey]!(actCtx);


wireHandlers() assumes actions[actionKey] exists (non-null asserted), but the compiled topology now includes an assess-semantic handler kind—createPiActions() currently doesn’t define assess-semantic, so brunch cook will throw once a slice reaches semantic assessment.

Severity: high

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}

augmentcode · 2026-05-22T12:42:04Z


-  const engine: Orchestrator =
-    opts.engine === 'petri' ? new PetriOrchestrator() : new ProceduralOrchestrator();
+  const engine = createOrchestrator('serial');


parseCookArgs() still accepts --engine proc|petri (and CookOptions.engine is populated), but runCook() now always constructs createOrchestrator('serial'), so the CLI engine selection is silently ignored.

Severity: medium

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit f959557. Configure here.}

cursor · 2026-05-22T14:16:36Z

+          const reworkCount = budgetToken.reworkCount ?? 0;
+
+          const reportId = await actions[actionKey]!(actCtx);
+          ctx.reportIds.push(reportId);


Missing assess-semantic cook handler

High Severity

The subnet now requires an assess-semantic transition before return-done, and wireHandlers invokes actions['assess-semantic'], but createPiActions (used by brunch cook) never registers that handler. Real fixture runs halt or throw once mechanical work reaches semantic assessment.

Additional Locations (1)

src/orchestrator/src/cook-cli.ts#L92-L96

^{Reviewed by Cursor Bugbot for commit f959557. Configure here.}

- Add semantic-gate and semantic-satisfied places per slice - Add assess-semantic transition joining done-spec + semantic-gate - On pass: produces semantic-satisfied → return-done proceeds - On fail: routes to needs-more, forcing another TDD rework cycle - return-done now consumes semantic-satisfied (not done-spec directly) - PlanDoneAccepted is topologically unreachable without semantic satisfaction - New contract test #10: semantic gate rejects then accepts - Updated all call-order assertions and adapter test counts Co-authored-by: Amp <amp@ampcode.com>

- Define TransitionContract type (kind, lane, actor, guard) in petri-net.ts - Add contract field to TransitionDef (optional, no behavioral change) - Populate contract metadata for all compiled transitions: mechanical-lane (evaluate, write-tests, write-code, run-tests), semantic-lane (assess-semantic, return-done), structural (slice-ready, epic-complete, epic-deps-met) - Add getTransitions() accessor on PetriNet for inspection - New adapter test verifies contract metadata classification Co-authored-by: Amp <amp@ampcode.com>

- Define NetEvent, NetEventKind, NetEventSink types in petri-net.ts - PetriNet.run() accepts optional event sink (backward compatible) - Emits transition_fired with id, contract, consumed/produced places - Emits net_halted when shouldHalt() triggers - Emits net_deadlocked when no transition enabled but tokens remain - New adapter tests: happy-path event capture + retry-exhaustion halt - Note: deadlock detection is coarse (leftover resource tokens trigger it on clean completion); refined detection is future work Co-authored-by: Amp <amp@ampcode.com>

Co-authored-by: Amp <amp@ampcode.com>

…dget - Split compilePlan into compileTopology (pure data → NetBlueprint) and wireHandlers (attaches fire closures). Adapter tests use topology-only. - Consolidate identical PetriOrchestrator/ProceduralOrchestrator into createOrchestrator(policy) factory. Delete engine-petri.ts/engine-proc.ts. - Move RunCtx from net-compiler.ts to types.ts (compiler is context-free). - Add semantic-budget place + reworkCount token to prevent infinite rework loops when assess-semantic always rejects (Finding #8 correctness fix). - HandlerDescriptor discriminated union (7 kinds) makes transition routing declarative in the blueprint. All descriptors carry actionKey explicitly. - New net-blueprint.ts for NetBlueprint/TransitionSkeleton/HandlerDescriptor types. - 1378 tests pass across 120 files. Co-authored-by: Amp <amp@ampcode.com>

…compilation Co-authored-by: Amp <amp@ampcode.com>

kostandinang mentioned this pull request May 21, 2026

FE-730: Orchestrator POC — dual-engine execution with contract tests #143

Open

kostandinang changed the title ~~FE-738: two-lane subnet with semantic completion gate~~ FE-738: Petri semantic lanes — two-lane subnet, compiler split, engine factory May 21, 2026

kostandinang marked this pull request as ready for review May 22, 2026 12:38

kostandinang mentioned this pull request May 22, 2026

FE-743: Petri parallel execution — concurrent firing, resource pools, worktree-per-slice #149

Open

cursor Bot reviewed May 22, 2026

View reviewed changes

augmentcode Bot reviewed May 22, 2026

View reviewed changes

kostandinang force-pushed the ka/fe-730-orchestrator-poc-dual-engine branch from b72d1ad to 934ea57 Compare May 22, 2026 14:14

kostandinang force-pushed the ka/fe-738-petri-semantic-lanes branch from 8e56a7c to f959557 Compare May 22, 2026 14:14

cursor Bot reviewed May 22, 2026

View reviewed changes

kostandinang and others added 6 commits May 22, 2026 16:58

plan: cards 1-3 done for petri-semantic-lanes, retire CARDS.md

ca156a1

Co-authored-by: Amp <amp@ampcode.com>

plan: petri-semantic-lanes done, criterion 5 deferred to petri-graph-…

1747538

…compilation Co-authored-by: Amp <amp@ampcode.com>

kostandinang force-pushed the ka/fe-738-petri-semantic-lanes branch from f959557 to 1747538 Compare May 22, 2026 14:59

kostandinang mentioned this pull request May 22, 2026

FE-745: Merge slice worktrees into epic-scoped dir for verify-epic #152

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FE-738: Petri semantic lanes — two-lane subnet, compiler split, engine factory#148

FE-738: Petri semantic lanes — two-lane subnet, compiler split, engine factory#148
kostandinang wants to merge 6 commits into
ka/fe-730-orchestrator-poc-dual-enginefrom
ka/fe-738-petri-semantic-lanes

kostandinang commented May 21, 2026 •

edited

Loading

Uh oh!

kostandinang commented May 21, 2026 •

edited

Loading

Uh oh!

cursor Bot commented May 22, 2026 •

edited

Loading

Uh oh!

Uh oh!

cursor Bot May 22, 2026

Uh oh!

augmentcode Bot commented May 22, 2026

Uh oh!

augmentcode Bot left a comment

Uh oh!

augmentcode Bot May 22, 2026 •

edited

Loading

Uh oh!

augmentcode Bot May 22, 2026 •

edited

Loading

Uh oh!

cursor Bot left a comment

Uh oh!

cursor Bot May 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

kostandinang commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Verification

Acceptance (per memory/PLAN.md)

Next

Uh oh!

kostandinang commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor Bot commented May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

Uh oh!

cursor Bot May 22, 2026

Choose a reason for hiding this comment

False net_deadlocked on success

Uh oh!

augmentcode Bot commented May 22, 2026

Uh oh!

augmentcode Bot left a comment

Choose a reason for hiding this comment

Uh oh!

augmentcode Bot May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

augmentcode Bot May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor Bot May 22, 2026

Choose a reason for hiding this comment

Missing assess-semantic cook handler

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

kostandinang commented May 21, 2026 •

edited

Loading

Acceptance (per `memory/PLAN.md`)

kostandinang commented May 21, 2026 •

edited

Loading

cursor Bot commented May 22, 2026 •

edited

Loading

augmentcode Bot May 22, 2026 •

edited

Loading

augmentcode Bot May 22, 2026 •

edited

Loading