NimBLEServer::serviceChanged() should be public to enable it being ca…

[chmorgan]

…lled outside of the library to indicate GATT changes

Summary by CodeRabbit

• Refactor
  • Server API enhancement: A previously internal method is now accessible for external integration and use.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: aa7d9204-ea88-4248-9690-642ec9ae7218

📥 Commits

Reviewing files that changed from the base of the PR and between 2cb68e2 and d4c5a0d.

📒 Files selected for processing (1)

• src/NimBLEServer.h

---

📝 Walkthrough

Walkthrough

Ahoy! The NimBLEServer::serviceChanged() method be sailin' from the private waters into the public seas. The method's signature remain unchanged—'tis merely the access level that be shiftin' from private to public in the class declaration, lettin' all scallywags use it openly.

Changes

Cohort / File(s)	Summary
Access Level Modification src/NimBLEServer.h	Moved void serviceChanged(); declaration from private section to public section, grantin' public access to the method whilst keepin' the signature intact.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🏴‍☠️ From shadows deep where private treasures dwell,
A method breaks its chains with mighty spell,
Now public shores do beckon all aboard,
serviceChanged() declares its new reward,
One line removed, one line raised high—
A pirate's gift beneath the code-y sky! ⚓

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely summarizes the main change: exposing NimBLEServer::serviceChanged() as a public method to allow external calls.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

You can validate your CodeRabbit configuration file in your editor.

If your editor has YAML language server, you can enable auto-completion and validation by adding # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json at the top of your CodeRabbit configuration file.

[h2zero]

Thanks @chmorgan !