Operation tests for setImmediates by shaoboyan091 · Pull Request #4558 · gpuweb/cts

shaoboyan091 · 2026-01-12T06:28:45Z

Implement operation tests for setImmediates in ComputePassEncoder, RenderPassEncoder, and RenderBundleEncoder.

Add basic execution tests for scalar, vector, and struct types.
Add tests for partial updates and multiple updates (using range verification).
Add tests for pipeline switching (compatible and incompatible).
Add tests for large data (maxImmediateSize) with range verification.
Add tests for TypedArray arguments with offsets.
Add tests for mixing render pass and bundle execution.

Issue: #

Requirements for PR author:

All missing test coverage is tracked with "TODO" or .unimplemented().
New helpers are /** documented */ and new helper files are found in helper_index.txt.
Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

Tests are properly located.
Test descriptions are accurate and complete.
Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
Tests avoid over-parameterization (see case count report).

When landing this PR, be sure to make any necessary issue status updates.

github-actions · 2026-01-12T06:31:07Z

Results for build job (at 1ddbf94):

+webgpu:api,operation,command_buffer,programmable,immediate:basic_execution:* - 51 cases, 51 subcases (~1/case)
+webgpu:api,operation,command_buffer,programmable,immediate:update_data:* - 3 cases, 3 subcases (~1/case)
+webgpu:api,operation,command_buffer,programmable,immediate:pipeline_switch:* - 4 cases, 4 subcases (~1/case)
+webgpu:api,operation,command_buffer,programmable,immediate:use_max_immediate_size:* - 3 cases, 3 subcases (~1/case)
+webgpu:api,operation,command_buffer,programmable,immediate:typed_array_arguments:* - 36 cases, 216 subcases (~6/case)
+webgpu:api,operation,command_buffer,programmable,immediate:multiple_updates_before_draw_or_dispatch:* - 3 cases, 3 subcases (~1/case)
+webgpu:api,operation,command_buffer,programmable,immediate:render_pass_and_bundle_mix:* - 1 cases, 1 subcases (~1/case)
+webgpu:api,operation,command_buffer,programmable,immediate:render_bundle_isolation:* - 1 cases, 1 subcases (~1/case)
-TOTAL: 280650 cases, 2321809 subcases
+TOTAL: 280752 cases, 2322091 subcases

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/webgpu/api/operation/command_buffer/programmable/immediate.spec.ts

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/webgpu/api/operation/command_buffer/programmable/immediate.spec.ts

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/webgpu/api/operation/command_buffer/programmable/immediate.spec.ts

Implement operation tests for setImmediates in ComputePassEncoder, RenderPassEncoder, and RenderBundleEncoder. - Add basic execution tests for scalar, vector, and struct types. - Add tests for partial updates and multiple updates (using range verification). - Add tests for pipeline switching (no inheritance). - Add tests for large data (maxImmediateSize) with range verification. - Add tests for TypedArray arguments with offsets. - Add tests for mixing render pass and bundle execution.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

shaoboyan091 · 2026-03-05T05:52:26Z

Softly ping for review.

src/webgpu/api/operation/command_buffer/programmable/immediate.spec.ts

Kangz · 2026-03-06T17:15:02Z

The operation tests seem to have good coverage. They became much simpler when the group decided to add validation that all immediates are set instead of defaulting to 0.

Kangz

Wow Github's code review UI is really annoying to use.

src/webgpu/api/operation/command_buffer/programmable/immediate.spec.ts

Kangz

Almost there

src/webgpu/api/operation/command_buffer/programmable/immediate.spec.ts

Kangz · 2026-03-10T14:41:54Z

src/webgpu/api/operation/command_buffer/programmable/immediate.spec.ts

+      .combine('typedArray', kTypedArrayBufferViewKeys)
+      .combine('encoderType', kProgrammableEncoderTypes)
+      .beginSubcases()
+      .combine('dataOffset', [undefined, 0, 2])


With these params, I don't think that the filter below is ever false?

Also why 2 and not other offsets/sizes? For uint8_t it will be an issue as a size of 2 is not a multiple. Instead can we make the dataSize depend on the BYTES_PER_ELEMENT to be either 1 element or 4 bytes (whichever is smaller)?

BYTES_PER_ELEMENT is a good idea, I think I could try param generator.

src/webgpu/api/operation/command_buffer/programmable/immediate.spec.ts

Kangz · 2026-03-10T14:46:58Z

src/webgpu/api/operation/command_buffer/programmable/immediate.spec.ts

+    });
+    t.device.queue.submit([commandEncoder.finish()]);
+
+    const expected = new Uint32Array(16);


Let's just reuse clearsData?

It will need to be hosted out of the encodeForPassType but that's ok to avoid copying the same filler pattern code twice.

Kangz · 2026-03-10T14:47:42Z

src/webgpu/api/operation/command_buffer/programmable/immediate.spec.ts

+      for (let i = 0; i < 16; i++) clearData[i] = 0xaaaaaaaa + i * 0x11111111;
+      enc.setImmediates!(0, clearData);
+
+      if (dataSize === undefined) {


I thought that passing undefined to the argument would cause the default values to be used, is that not the case and we need to make calls with different numbers of parameters?

Kangz · 2026-03-10T14:48:36Z

src/webgpu/api/operation/command_buffer/programmable/immediate.spec.ts

+    for (let i = 0; i < 16; i++) expected[i] = 0xaaaaaaaa + i * 0x11111111;
+    const expectedView = new Uint8Array(expected.buffer);
+
+    for (let i = 0; i < actualDataSize; i++) {


Instead of replicating the conversion, can we copy from view into the correct spot in expected ?

There is a memcpy utility somewhere in the CTS IIRC

Kangz · 2026-03-10T14:54:38Z

src/webgpu/api/operation/command_buffer/programmable/immediate.spec.ts

+    const actualDataSize = dataSize ?? maxElementsIn64Bytes - actualDataOffset;
+
+    // Create a typed array buffer. If dataSize is undefined, we shouldn't add padding
+    // because setImmediates uses the rest of the array, which would exceed our intended size or break the % 4 rule.


The padding of 0 or 4 doesn't improve the % 4 rule because both of these numbers are multiples of 4. We need to make the actualDataSize smaller when BYTES_PER_ELEMENT is no a multiple of 4, so that the dataSize == undefined case passes validation. And then we can add paddingElements on top of that.

shaoboyan091 · 2026-03-13T02:37:03Z

I think I've resolved comments. PTAL, thanks !

Kangz · 2026-03-13T17:22:49Z

src/webgpu/api/operation/command_buffer/programmable/immediate.spec.ts

    // Pipeline A always uses vec4<u32> (16 bytes).
    const wgslDeclA = 'var<immediate> data: vec4<u32>;';
    const copyCodeA = `
      let base = outIndex * 4;


Did your AI start rewriting this test for some reason?

In any case, base is no longer used here.

Kangz · 2026-03-13T17:28:17Z

src/webgpu/api/operation/command_buffer/programmable/immediate.spec.ts

    const arr = new Ctor(actualDataOffset + actualDataSize + paddingElements);
    const view = new DataView(arr.buffer);

+    // Fill the data region with a recognizable byte pattern.


This could be a single loop over actualDataSize + elementSize, or better over the byte size of view

shaoboyan091 force-pushed the immediate-operation branch from 834cd4a to 509b754 Compare February 10, 2026 08:41

shaoboyan091 requested a review from Copilot February 10, 2026 08:42

Copilot started reviewing on behalf of shaoboyan091 February 10, 2026 08:43 View session

Copilot AI reviewed Feb 10, 2026

View reviewed changes

shaoboyan091 requested a review from Copilot February 11, 2026 01:48

Copilot started reviewing on behalf of shaoboyan091 February 11, 2026 01:49 View session

Copilot AI reviewed Feb 11, 2026

View reviewed changes

shaoboyan091 force-pushed the immediate-operation branch 2 times, most recently from 2c527ae to ffe4c7c Compare February 24, 2026 06:26

shaoboyan091 requested a review from Copilot February 24, 2026 06:28

Copilot started reviewing on behalf of shaoboyan091 February 24, 2026 06:28 View session

Copilot AI reviewed Feb 24, 2026

View reviewed changes

src/webgpu/api/operation/command_buffer/programmable/immediate.spec.ts Show resolved Hide resolved

src/webgpu/api/operation/command_buffer/programmable/immediate.spec.ts Outdated Show resolved Hide resolved

shaoboyan091 force-pushed the immediate-operation branch 2 times, most recently from 4c8a817 to 7e4e8d8 Compare February 24, 2026 07:26

shaoboyan091 requested a review from Copilot February 24, 2026 07:49

Copilot started reviewing on behalf of shaoboyan091 February 24, 2026 07:49 View session

Copilot AI reviewed Feb 24, 2026

View reviewed changes

shaoboyan091 force-pushed the immediate-operation branch from 7e4e8d8 to 2e3521f Compare February 24, 2026 07:56

shaoboyan091 force-pushed the immediate-operation branch from 2e3521f to 6f16cf5 Compare February 24, 2026 08:33

shaoboyan091 requested a review from Copilot February 24, 2026 08:34

Copilot started reviewing on behalf of shaoboyan091 February 24, 2026 08:34 View session

Copilot AI reviewed Feb 24, 2026

View reviewed changes

shaoboyan091 requested review from Kangz and kainino0x February 24, 2026 08:39

Kangz reviewed Mar 6, 2026

View reviewed changes

Address comments

079a9cd

shaoboyan091 marked this pull request as draft March 9, 2026 08:45

Kangz reviewed Mar 9, 2026

View reviewed changes

Iterate

f57ee4e

Kangz reviewed Mar 10, 2026

View reviewed changes

Iterating on typed array case and use outIndex every where

1ddbf94

shaoboyan091 marked this pull request as ready for review March 13, 2026 02:36

shaoboyan091 requested a review from Kangz March 13, 2026 02:36

Kangz approved these changes Mar 13, 2026

View reviewed changes

Conversation

shaoboyan091 commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

shaoboyan091 commented Mar 5, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Kangz commented Mar 6, 2026

Uh oh!

Kangz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Kangz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shaoboyan091 commented Jan 12, 2026 •

edited

Loading

github-actions bot commented Jan 12, 2026 •

edited

Loading