feat(storage): skip unnecessary checksum computation during read_object#5134
Merged
vsharonlynn merged 8 commits intogoogleapis:mainfrom Mar 31, 2026
Conversation
product-auto-label
Bot
added
the
api: storage
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5134 +/- ##
==========================================
- Coverage 98.02% 98.02% -0.01%
==========================================
Files 214 214
Lines 44186 44217 +31
==========================================
+ Hits 43313 43343 +30
- Misses 873 874 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vsharonlynn
force-pushed
the
feat/storage-read-object-optimize-checksum-operations
branch
2 times, most recently
from
7732fb5 to
a52674a
Compare
vsharonlynn
force-pushed
the
feat/storage-read-object-optimize-checksum-operations
branch
2 times, most recently
from
0aa3f31 to
8acdeb7
Compare
Contributor
Author
|
Double-checking this PR. |
vsharonlynn
deleted the
feat/storage-read-object-optimize-checksum-operations
branch
vsharonlynn
restored the
feat/storage-read-object-optimize-checksum-operations
branch
vsharonlynn
force-pushed
the
feat/storage-read-object-optimize-checksum-operations
branch
from
8acdeb7 to
45924a9
Compare
Contributor
Author
|
More details about this PR: This change optimises for read ranges by short-circuiting the computation if the server returns empty checksums (regardless of request options). It solves "checksums should be disabled by default when downloading a range" in the issue. |
coryan
reviewed
Mar 30, 2026
Contributor
coryan
left a comment
coryan
left a comment
There was a problem hiding this comment.
I don't understand the need for a should_track_checksums flag.
vsharonlynn
changed the title
vsharonlynn
force-pushed
the
feat/storage-read-object-optimize-checksum-operations
branch
from
45924a9 to
fdabae2
Compare
coryan
approved these changes
Mar 31, 2026
vsharonlynn
deleted the
feat/storage-read-object-optimize-checksum-operations
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation to issue #4285.