Skip to content

fix(crc32c): Drop support for Python 3.8 and 3.9#16955

Merged
parthea merged 12 commits intomainfrom
feat/drop-python-3.7-3.9-google-crc32c
May 6, 2026
Merged

fix(crc32c): Drop support for Python 3.8 and 3.9#16955
parthea merged 12 commits intomainfrom
feat/drop-python-3.7-3.9-google-crc32c

Conversation

@chalmerlowe
Copy link
Copy Markdown
Contributor

This PR updates `google-crc32c` to establish Python 3.10 as the minimum supported version, dropping support for Python 3.7, 3.8, and 3.9.

Changes

  • Configuration: Updated `setup.cfg` and `pyproject.toml` to require Python 3.10+ and remove references to Python 3.8 and 3.9.
  • Nox: Updated `noxfile.py` to remove Python 3.7, 3.8, and 3.9 from unit test versions.
  • Documentation: Updated `README.md` to reflect supported Python versions and published wheels.

Note: Verification tests were skipped locally due to environment issues with building the C library in the Docker container, but changes are strictly metadata and configuration!

Fixes internal issue: http://b/482126936 🦕

@chalmerlowe chalmerlowe requested a review from a team as a code owner May 5, 2026 20:13
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request drops support for Python versions below 3.10, updating the README, Noxfile, pyproject.toml, and setup.cfg accordingly. A review comment identifies that Python 3.13 and 3.14 are missing from the classifiers in setup.cfg, which should be added to ensure consistency with the documentation and test matrix.

I am having trouble creating individual review comments. Click here to see my feedback.

packages/google-crc32c/setup.cfg (32-33)

medium

The classifiers section in setup.cfg is missing entries for Python 3.13 and 3.14. Since these versions are explicitly listed as supported in the README.md and are included in the noxfile.py test matrix, they should be added to the metadata to ensure consistency and to correctly signal support on PyPI.

@chalmerlowe chalmerlowe added this to the Drop support for 3.7-3.9 milestone May 5, 2026
@parthea parthea changed the title feat(crc32c): Drop support for Python 3.7, 3.8, and 3.9 fix(crc32c): Drop support for Python 3.8 and 3.9 May 6, 2026
@parthea parthea merged commit d5bea2e into main May 6, 2026
30 checks passed
@parthea parthea deleted the feat/drop-python-3.7-3.9-google-crc32c branch May 6, 2026 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants