Skip to content

feat(mapmanagement): add google-maps-mapmanagement#16930

Open
noahdietz wants to merge 1 commit intogoogleapis:mainfrom
noahdietz:chore-onboard-mapmanagement-2026-05-04
Open

feat(mapmanagement): add google-maps-mapmanagement#16930
noahdietz wants to merge 1 commit intogoogleapis:mainfrom
noahdietz:chore-onboard-mapmanagement-2026-05-04

Conversation

@noahdietz
Copy link
Copy Markdown
Contributor

Onboard google-maps-mapmanagement API with initial v2beta version.

Produced by running the following commands:

$ V=$(sed -n 's/^version: *//p' librarian.yaml)
$ go run github.com/googleapis/librarian/tool/cmd/builddockerimages@${V} --version ${V} --language python
$ go run github.com/googleapis/librarian/cmd/librarian@${V} add google/maps/mapmanagement/v2beta
$ docker run -u $(id -u):$(id -g) -v .:/repo -v ~/.cache:/.cache -w /repo docker.io/library/librarian-python:${V}  generate google-maps-mapmanagement

Towards b/503325033

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the google-maps-mapmanagement library, providing a Python client for the Map Management API v2beta. The implementation includes generated GAPIC code, comprehensive documentation, and automated test configurations. Feedback was provided to correct a duplicate word in the MapManagementAsyncClient docstring and to fix an invalid version for the ruff linter in the noxfile.py while ensuring consistency with shared project configurations.

"""The Map Management API uses your inputs to create and manage Google
Cloud based styling resources for Google Maps.

Using this API, you can can create and manage MapConfigs (Map IDs),
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There is a duplicate word "can" in the docstring.

Suggested change
Using this API, you can can create and manage MapConfigs (Map IDs),
Using this API, you can create and manage MapConfigs (Map IDs),

from typing import Dict, List

import nox

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The version 0.14.14 for ruff appears to be invalid or a typo, as the current stable versions are in the 0.9.x range. Please verify the intended version. Note that changes to shared configurations should be applied consistently across all relevant packages in a dedicated, universal change rather than piecemeal in individual pull requests.

Suggested change
RUFF_VERSION = "ruff==0.9.6"
References
  1. Changes to shared configurations, like mypy flags, should be applied consistently across all relevant packages in a dedicated, universal change rather than piecemeal in individual pull requests.

@noahdietz noahdietz marked this pull request as ready for review May 4, 2026 22:11
@noahdietz noahdietz requested review from a team as code owners May 4, 2026 22:11
@snippet-bot
Copy link
Copy Markdown

snippet-bot Bot commented May 4, 2026

Here is the summary of changes.

You are about to add 30 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Copy link
Copy Markdown
Contributor

@jskeet jskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from the Librarian config files side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants