Skip to content

chore(gitignore): exclude java code packages from global python env patterns#13003

Merged
meltsufin merged 2 commits intomainfrom
fix/gitignore-package-collision
May 6, 2026
Merged

chore(gitignore): exclude java code packages from global python env patterns#13003
meltsufin merged 2 commits intomainfrom
fix/gitignore-package-collision

Conversation

@meltsufin
Copy link
Copy Markdown
Member

This will be needed for java-bigtable.
Example: java-bigtable/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/test_helpers/env/PrefixGenerator.java

@meltsufin meltsufin requested a review from a team as a code owner May 5, 2026 02:29
@meltsufin meltsufin requested a review from blakeli0 May 5, 2026 02:29
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the .gitignore file to prevent Java and Proto source directories named env/ or ENV/ from being ignored by global Python virtual environment rules. The reviewer suggested simplifying these patterns to a more maintainable and consistent format that covers all source directories under src/.

Comment thread .gitignore Outdated
@meltsufin meltsufin enabled auto-merge (squash) May 5, 2026 16:56
@meltsufin meltsufin merged commit 9ecc251 into main May 6, 2026
121 of 124 checks passed
@meltsufin meltsufin deleted the fix/gitignore-package-collision branch May 6, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants