Skip to content

impl(bigtable): generate AsyncPingAndWarm method#16026

Open
scotthart wants to merge 3 commits intogoogleapis:mainfrom
scotthart:bigtable_generate_async_ping
Open

impl(bigtable): generate AsyncPingAndWarm method#16026
scotthart wants to merge 3 commits intogoogleapis:mainfrom
scotthart:bigtable_generate_async_ping

Conversation

@scotthart
Copy link
Member

No description provided.

@scotthart scotthart requested a review from a team as a code owner March 4, 2026 00:11
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Mar 4, 2026
@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates the AsyncPingAndWarm method into the Google Cloud Bigtable C++ client library. The changes involve updating the service definition, implementing the asynchronous method across the core stub and its various internal decorators, and ensuring proper handling of authentication, channel management, logging, metadata, and tracing. This enhancement provides clients with a new asynchronous capability to interact with Bigtable instances for ping and warm operations.

Highlights

  • New Async Method: Introduced the AsyncPingAndWarm method across the Bigtable client library, enabling asynchronous ping and warm operations.
  • Service Configuration Update: Updated the generator_config.textproto to include PingAndWarm in the list of services, allowing for its generation.
  • Decorator Pattern Implementation: Implemented the AsyncPingAndWarm method in various internal decorator classes, including authentication, channel refresh, logging, metadata, and round-robin decorators, ensuring consistent behavior and feature integration.
  • Metadata Routing: Added metadata routing logic for AsyncPingAndWarm to correctly handle name and app_profile_id parameters.
  • Tracing Integration: Integrated OpenTelemetry tracing for the new AsyncPingAndWarm method to provide observability.
  • Testing Support: Added a mock method for AsyncPingAndWarm in the testing framework to facilitate unit and integration testing.
Changelog
  • generator/generator_config.textproto
    • Added "PingAndWarm" to the list of services.
  • google/cloud/bigtable/internal/bigtable_auth_decorator.cc
    • Implemented the AsyncPingAndWarm method with authentication logic.
  • google/cloud/bigtable/internal/bigtable_auth_decorator.h
    • Declared the AsyncPingAndWarm method in the BigtableAuth class.
  • google/cloud/bigtable/internal/bigtable_channel_refresh.cc
    • Implemented the AsyncPingAndWarm method for channel refresh.
  • google/cloud/bigtable/internal/bigtable_channel_refresh.h
    • Declared the AsyncPingAndWarm method in the BigtableChannelRefresh class.
  • google/cloud/bigtable/internal/bigtable_logging_decorator.cc
    • Implemented the AsyncPingAndWarm method with logging.
  • google/cloud/bigtable/internal/bigtable_logging_decorator.h
    • Declared the AsyncPingAndWarm method in the BigtableLogging class.
  • google/cloud/bigtable/internal/bigtable_metadata_decorator.cc
    • Implemented the AsyncPingAndWarm method with metadata routing for name and app_profile_id.
  • google/cloud/bigtable/internal/bigtable_metadata_decorator.h
    • Declared the AsyncPingAndWarm method in the BigtableMetadata class.
  • google/cloud/bigtable/internal/bigtable_round_robin_decorator.cc
    • Implemented the AsyncPingAndWarm method for round-robin distribution.
  • google/cloud/bigtable/internal/bigtable_round_robin_decorator.h
    • Declared the AsyncPingAndWarm method in the BigtableRoundRobin class.
  • google/cloud/bigtable/internal/bigtable_stub.cc
    • Implemented the default AsyncPingAndWarm method.
  • google/cloud/bigtable/internal/bigtable_stub.h
    • Declared the virtual AsyncPingAndWarm method in BigtableStub and DefaultBigtableStub.
  • google/cloud/bigtable/internal/bigtable_tracing_stub.cc
    • Implemented the AsyncPingAndWarm method with OpenTelemetry tracing.
  • google/cloud/bigtable/internal/bigtable_tracing_stub.h
    • Declared the AsyncPingAndWarm method in the BigtableTracingStub class.
  • google/cloud/bigtable/testing/mock_bigtable_stub.h
    • Added a mock declaration for the AsyncPingAndWarm method.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements the AsyncPingAndWarm method for the Bigtable service. The changes are mostly generated code, stemming from an update to the generator configuration. I've reviewed the generated code across all the stub decorators (auth, channel refresh, logging, metadata, round-robin, and tracing), as well as the base stub implementation and the mock stub for testing. The implementation is consistent with the existing asynchronous methods in the codebase and appears to be correct. No issues were found.

@codecov
Copy link

codecov bot commented Mar 4, 2026

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.63%. Comparing base (ced8a7c) to head (e58a71c).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...loud/bigtable/internal/bigtable_channel_refresh.cc 0.00% 3 Missing ⚠️
google/cloud/bigtable/testing/mock_bigtable_stub.h 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16026      +/-   ##
==========================================
- Coverage   92.63%   92.63%   -0.01%     
==========================================
  Files        2333     2333              
  Lines      214631   214635       +4     
==========================================
+ Hits       198827   198829       +2     
- Misses      15804    15806       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the Bigtable API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant