Fix launch with kernel repacking#2531
Merged
Databean merged 1 commit intogoogle:mainfrom May 8, 2026
Merged
Conversation
At some point assemble_cvd expected `cpio` to return non-zero values on success, which is no longer true. Newer versions of cpio return 0 on success. Ignoring the return value of cpio seems to work, the kernel is replaced successfully. Tested with: ``` bazel-bin/cuttlefish/package/cuttlefish-common/bin/cvd fetch --default_build=git_main/aosp_cf_x86_64_only_phone-trunk_staging-userdebug --target_directory=$HOME/dl_kernel --kernel_build=aosp_kernel-common-android-mainline/kernel_virt_x86_64 bazel-bin/cuttlefish/package/cuttlefish-common/bin/cvd create --host_path=$HOME/dl_kernel --product_path=$HOME/dl_kernel ``` Bug: b/427835411 Bug: b/510369069
jemoreira
approved these changes
May 7, 2026
Member
Author
|
Thanks for reviewing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At some point assemble_cvd expected
cpioto return non-zero values on success, which is no longer true. Newer versions of cpio return 0 on success. Ignoring the return value of cpio seems to work, the kernel is replaced successfully.Tested with:
Bug: b/427835411
Bug: b/510369069