Trim down cvd create output#2523
Merged
cjreynol merged 10 commits intogoogle:mainfrom May 8, 2026
Merged
Conversation
cjreynol
changed the title
cvd create output
cjreynol
added
kokoro:force-run
GoogleCuttlefishTesterBot
removed
kokoro:run
This logic is going to be revisted for metrics gathering as part of b/492179685. Bug: 507537392
To trim down the `cvd create` output. Bug: 507537392
cjreynol
added
kokoro:force-run
GoogleCuttlefishTesterBot
removed
kokoro:run
jemoreira
approved these changes
May 7, 2026
This message is always output when starting a device, partly because of the V2 metrics. There is no reason to duplicate it, and the V1 metrics confirmation dialog will be removed when V2 metrics are complete (b/463443661). Also, trimmed down the messages that use identical language to previous notices. Bug: 507537392
Trying to trim down the `cvd create` output. Bug: 507537392
Also, trim the message to minimize output in `cvd create` noise. Bug: 507537392
In favor of directing users towards the new `cvd logs` command. Bug: 507537392
Trying to trim down the `cvd create` output. Bug: 507537392
Trying to trim down `cvd create` output. Also, I moved the printing of that message until AFTER the file existence check is run. If it does not exist, it is not being read. Bug: 507537392
The remaining message is the one that is printed to the console for the user. Bug: 507537392
And make the failed message log at the error level to match the reasoning for the message. Users do not need to see that message when the "Virutal device booted successfully" already exists. Bug: 507537392
cjreynol
added
kokoro:run
GoogleCuttlefishTesterBot
removed
kokoro:run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: 507537392