refactor: use sourcegraph/run for command execution#127
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
os/exec-based command execution incommand.gowithgithub.com/sourcegraph/run, delegating process lifecycle management to the libraryRunInDir,RunInDirPipeline,RunInDirWithOptions,Run) and all behavioral contracts (default timeout, cancellation →context.Canceled, deadline →ErrExecTimeout, stderr in errors, debug logging)run.Arg()to properly quote arguments for the library's shell-based parser, andOutput.Stream()for raw byte-preserving output (important for binary-ish output likels-tree -z)All existing tests pass without modification.