Add query builders for separate SELECT+INSERT copy queries#1679
Draft
danieljoos wants to merge 2 commits into
Draft
Add query builders for separate SELECT+INSERT copy queries#1679danieljoos wants to merge 2 commits into
danieljoos wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Pull Request should be associated with an Issue.
Related issue (public): #1681
Related issue (internal): https://github.com/github/database-infrastructure/issues/8163
Description
This PR is part of the move-tables feature development PR stack.
It introduces query builders for separate
SELECT+INSERTqueries that are used for the move-tables mode instead of the range-INSERTquery that usually runs on the primary host.For move-tables the copy step needs to first
SELECTon the source, thenINSERTon the target. Of course this comes with much higher cost: copying the data to and from the host that runsgh-ost.script/cibuildreturns with no formatting errors, build errors or unit test errors.