[log] Add cache hit and creation debug logging to filteredServerCache#5440
Draft
github-actions[bot] wants to merge 1 commit intomainfrom
Draft
[log] Add cache hit and creation debug logging to filteredServerCache#5440github-actions[bot] wants to merge 1 commit intomainfrom
github-actions[bot] wants to merge 1 commit intomainfrom
Conversation
Log cache creation parameters and cache hits to aid debugging of session-scoped filtered server lifecycle. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds two targeted debug log calls to
internal/server/routed.go:newFilteredServerCache— logs the TTL and max-size at cache creation time, useful for verifying session timeout configuration at a glance.getOrCreate— logs a[CACHE] Cache hitline when a cached server entry is reused, complementing the existing miss/eviction log lines.Changes
internal/server/routed.go: +2logRouted.Printfcalls using the existinglogRoutedlogger (server:routed).Motivation
The existing cache logging covered eviction paths (TTL expiry and LRU eviction) but not cache hits or initial cache creation. This gap made it harder to distinguish between cache warm-up and steady-state operation when debugging session handling under load.
Validation
go build ./...— passesgo test ./internal/server/...— passes