Refactor duplicated gojq execution path in jqschema middleware

[Copilot]

✨ Enhancement

applyJqSchema and applyToolResponseFilter each implemented nearly identical gojq execution/timeout/error-handling logic, creating a maintenance hotspot in one file. This change consolidates that shared path into a single helper while preserving behavior-specific differences (notably tool-filter multi-result enforcement).

• What does this improve?

  • Removes duplicated gojq run/error logic from two middleware functions.
  • Centralizes timeout + gojq.HaltError + context-cancellation handling in one place.
  • Keeps per-callsite semantics intact (jq query execution failed wording for schema path, multi-result rejection for tool response filters).

• Why is this valuable?

  • Future changes to jq execution behavior now land in one code path instead of two.
  • Reduces risk of drift between schema filtering and tool response filtering error behavior.

• Implementation approach:

  • Added private helper runJqCode(...) with runJqCodeOptions for controlled per-caller behavior:
    • optional timeout logging
    • optional execution error prefix override
    • optional single-result enforcement
  • Updated:
    • applyJqSchema to delegate to runJqCode with schema-specific execution prefix.
    • applyToolResponseFilter to delegate with CheckMultipleResults: true.
  • Added focused tests for tool-response filter edge contracts:
    • no output (empty) returns tool response filter returned no results
    • multi-output (.[]) returns tool response filter returned multiple results...

v, err := runJqCode(ctx, jqSchemaCode, jsonData, "jq schema filter", runJqCodeOptions{
    ExecutionPrefix:   "jq query",
    LogDefaultTimeout: true,
})

return runJqCode(ctx, code, jsonData, "tool response filter", runJqCodeOptions{
    CheckMultipleResults: true,
})

[Copilot]

Pull request overview

Refactors internal/middleware/jqschema.go to remove duplicated gojq execution/timeout/error-handling logic by introducing a shared helper, while preserving the distinct error-message prefixes and the tool-response filter’s single-result contract.

Changes:

• Added runJqCode(...) + runJqCodeOptions to centralize gojq execution, default-timeout application, and gojq.HaltError/context error handling.
• Updated applyJqSchema and applyToolResponseFilter to delegate to runJqCode, with schema-specific execution prefixing and tool-filter multi-result enforcement.
• Added targeted tests covering “no results” and “multiple results” edge cases for tool-response filters.

Show a summary per file

File	Description
internal/middleware/jqschema.go	Consolidates duplicated gojq execution logic into runJqCode while keeping caller-specific semantics (execution prefix + multi-result enforcement).
internal/middleware/jqschema_test.go	Adds tests for tool response filter edge contracts (empty output and multi-output).

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 2/2 changed files
• Comments generated: 0