Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
✅ Coverage Check PassedOverall Coverage
📁 Per-file Coverage Changes (2 files)
Coverage comparison generated by |
Smoke Test Results
Status: 3/4 tests passed
|
Smoke Test: Copilot BYOK (Offline) Mode
Running in BYOK offline mode ( Overall: FAIL — pre-step data was not injected (template variables unresolved). BYOK inference path itself is ✅.
|
🤖 Smoke Test Results
Overall: PARTIAL Author:
|
Smoke TestPRs: fix: unexport test-only command option types; refactor: extract shared logger mock factory to test-utils Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "registry.npmjs.org"See Network Configuration for more information.
|
There was a problem hiding this comment.
Pull request overview
Adds additional Jest unit tests to exercise previously uncovered branches in src/host-iptables.ts, increasing confidence in security-sensitive host iptables rule setup/cleanup behavior without requiring real Docker/iptables execution.
Changes:
- Add new
setupHostIptablestests coveringcliProxyConfighost-gateway allow rules (including missing Docker bridge gateway). - Add new IPv6 DNS tests covering
ip6tablesavailable/unavailable paths and existing IPv6 chain cleanup. - Add targeted tests for error/edge branches: DOCKER-USER chain creation failure, invalid Docker bridge gateway IPv4 handling, and cleanup behavior when bridge name is unavailable.
Show a summary per file
| File | Description |
|---|---|
src/host-iptables.test.ts |
Adds 8 new deterministic tests to cover additional host-iptables.ts branches (cli proxy host access, IPv6 DNS handling, and cleanup/error edge cases). |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
Smoke Test Results
Overall: FAIL — service containers are not reachable from this environment.
|
🏗️ Build Test Suite Results
Overall: 8/8 ecosystems passed — ✅ PASS
|
🧪 Chroot Runtime Version Comparison
Result: ❌ Not all tests passed — Python and Node.js versions differ between host and chroot.
|
Summary
Adds 8 new tests covering previously uncovered branches in
src/host-iptables.ts, improving branch coverage from 55.55% (10/18) toward higher coverage.Changes
src/host-iptables.test.ts— 232 lines added, 8 new test casesSecurity-Critical Paths Now Covered
cliProxyConfigpathcliProxyConfig+ null Docker gatewayFW_WRAPPER_V6chain and adds IPv6 DNS allowlist rulesFW_WRAPPER_V6cleanupDOCKER-USERchain creation failuregetDockerBridgeGatewayinvalid IPv4cleanupHostIptableswith null bridgeBefore / After
host-iptables.ts)Test Design
All tests follow existing patterns:
execawithjest.mock()__testing._resetIpv6State()inbeforeEachNo Bugs Found
All uncovered branches appear to work correctly. The
getDockerBridgeGatewayIPv4 validation (preventing injection of arbitrary strings into iptables rules) is a good security safeguard that is now tested.