Skip to content

C/C++ overlay: fix entity discard for transitively included headers #21378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
IdrissRio wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −3
Draft

C/C++ overlay: fix entity discard for transitively included headers #21378

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions cpp/ql/lib/semmle/code/cpp/internal/Overlay.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,13 +97,18 @@ overlay[local]
private predicate isBase() { not isOverlay() }

/**
* Holds if `path` was extracted in the overlay database.
* Holds if `path` is a file whose entities should be discarded from the base.
* This covers explicitly changed files and source files compiled by the
* overlay, but not headers pulled in only as transitive includes.
*/
overlay[local]
private predicate overlayHasFile(string path) {
isOverlay() and
files(_, path) and
path != ""
(
overlayChangedFiles(path)
or
exists(@file f | compilation_compiling_files(_, _, f) and files(f, path))
)
}

/**
Expand Down
Loading