Skip to content

Shared: address review comments.

6f4adb8
Select commit
Loading
Failed to load commit list.
Merged

Shared/Java: Add shared Guards library and switch Java to use it. #19573

Shared: address review comments.
6f4adb8
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL completed Jun 26, 2025 in 8s

6 configurations not found

Warning: Code scanning may not have found all the alerts introduced by this pull request, because 6 configurations present on refs/heads/main were not found:

Actions workflow (rust-analysis.yml)

  • ❓  .github/workflows/rust-analysis.yml:analyze/language:rust

Actions workflow (csv-coverage-metrics.yml)

  • ❓  .github/workflows/csv-coverage-metrics.yml:publish-csharp
  • ❓  .github/workflows/csv-coverage-metrics.yml:publish-java

Actions workflow (codeql-analysis.yml)

  • ❓  .github/workflows/codeql-analysis.yml:CodeQL-Build/language:actions
  • ❓  .github/workflows/codeql-analysis.yml:CodeQL-Build/language:csharp

Actions workflow (cpp-swift-analysis.yml)

  • ❓  .github/workflows/cpp-swift-analysis.yml:CodeQL-Build

New alerts in code changed by this pull request

  • 2 warnings

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 386 in java/ql/lib/semmle/code/java/controlflow/Guards.qll

See this annotation in the file changed.

Code scanning / CodeQL

Names only differing by case Warning

SSA is only different by casing from Ssa that is used elsewhere for modules.

Check warning on line 542 in shared/controlflow/codeql/controlflow/Guards.qll

See this annotation in the file changed.

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
LogicInput
.