Skip to content

test(openai-agents): Replace mocks with httpx in MCP tool tests#5605

Open
alexander-alderman-webb wants to merge 2 commits intomasterfrom
webb/openai-agents/mcp-tool-tests
Open

test(openai-agents): Replace mocks with httpx in MCP tool tests#5605
alexander-alderman-webb wants to merge 2 commits intomasterfrom
webb/openai-agents/mcp-tool-tests

Conversation

@alexander-alderman-webb
Copy link
Contributor

@alexander-alderman-webb alexander-alderman-webb commented Mar 6, 2026

Description

Replace mocks with httpx types to avoid test failures when library internals change.

Issues

Reminders

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


Bug Fixes 🐛

  • (celery) Propagate user-set headers by sentrivana in #5581
  • (utils) Avoid double serialization of strings in safe_serialize by ericapisani in #5587

Documentation 📚

  • (openai-agents) Remove inapplicable comment by alexander-alderman-webb in #5495
  • Add AGENTS.md by sentrivana in #5579
  • Add set_attribute example to changelog by sentrivana in #5578

Internal Changes 🔧

Openai Agents

  • Replace mocks with httpx in MCP tool tests by alexander-alderman-webb in #5605
  • Expect namespace tool field for new openai versions by alexander-alderman-webb in #5599

🤖 This preview updates automatically when you update the PR.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

Codecov Results 📊

52 passed | Total: 52 | Pass Rate: 100% | Execution Time: 6.70s

📊 Comparison with Base Branch

Metric Change
Total Tests
Passed Tests
Failed Tests
Skipped Tests

✨ No test changes detected

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 14816 uncovered lines.
❌ Project coverage is 25.64%. Comparing base (base) to head (head).

Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
- Coverage    25.65%    25.64%    -0.01%
==========================================
  Files          189       189         —
  Lines        19924     19924         —
  Branches      6458      6458         —
==========================================
+ Hits          5111      5108        -3
- Misses       14813     14816        +3
- Partials       431       430        -1

Generated by Codecov Action

@alexander-alderman-webb alexander-alderman-webb marked this pull request as ready for review March 6, 2026 13:35
@alexander-alderman-webb alexander-alderman-webb requested a review from a team as a code owner March 6, 2026 13:35
@alexander-alderman-webb alexander-alderman-webb changed the title test(openai-agents): Replace mocks with httpx in MCP tool tests test(openai-agents): Replace mocks with httpx in MCP tool tests Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants