ref(anthropic): Factor out streamed result handling#5563
Draft
alexander-alderman-webb wants to merge 3 commits intomasterfrom
Draft
ref(anthropic): Factor out streamed result handling#5563alexander-alderman-webb wants to merge 3 commits intomasterfrom
alexander-alderman-webb wants to merge 3 commits intomasterfrom
Conversation
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛Openai
Other
Documentation 📚
Internal Changes 🔧Agents
Anthropic
Openai Agents
Other
🤖 This preview updates automatically when you update the PR. |
Contributor
Codecov Results 📊✅ 13 passed | Total: 13 | Pass Rate: 100% | Execution Time: 7.46s All tests are passing successfully. ❌ Patch coverage is 0.00%. Project has 13735 uncovered lines. Files with missing lines (180)
Generated by Codecov Action |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
+513
to
+516
| is_streaming_response = kwargs.get("stream", False) | ||
| if is_streaming_response: | ||
| _patch_streaming_response_iterator(result, span, integration) | ||
| return result |
Contributor
There was a problem hiding this comment.
Streaming response handling no longer protected by capture_internal_exceptions
The streaming path now checks kwargs.get("stream", False) and calls _patch_streaming_response_iterator before entering the capture_internal_exceptions() block. Previously, the streaming detection (hasattr(result, "_iterator")) was inside the exception handling block. If stream=True is passed but the result unexpectedly lacks _iterator (e.g., API behavior change, error responses), an AttributeError will propagate instead of being gracefully handled, potentially breaking the instrumented code path.
Verification
Read anthropic.py lines 510-520 to verify the new streaming check is outside capture_internal_exceptions(). The old code had elif hasattr(result, "_iterator"): inside the with capture_internal_exceptions(): block per the diff context. The new code at lines 513-516 executes before entering the block at line 518.
Suggested fix: Wrap the streaming response handling in capture_internal_exceptions to maintain defensive error handling
Suggested change
| is_streaming_response = kwargs.get("stream", False) | |
| if is_streaming_response: | |
| _patch_streaming_response_iterator(result, span, integration) | |
| return result | |
| with capture_internal_exceptions(): | |
| is_streaming_response = kwargs.get("stream", False) | |
| if is_streaming_response: | |
| _patch_streaming_response_iterator(result, span, integration) | |
| return result |
Identified by Warden code-review · TGC-FD8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issues
Reminders
tox -e linters.feat:,fix:,ref:,meta:)