chore(deps-dev): bump svelte from 3.59.2 to 5.53.5#19568
chore(deps-dev): bump svelte from 3.59.2 to 5.53.5#19568dependabot[bot] wants to merge 1 commit intodevelopfrom
Conversation
| "@sveltejs/vite-plugin-svelte": "1.4.0", | ||
| "@testing-library/svelte": "^3.2.1", | ||
| "svelte": "3.59.2", | ||
| "svelte": "5.53.5", |
There was a problem hiding this comment.
Major version bump breaks incompatible companion dev dependencies
High Severity
Bumping svelte from 3.59.2 to 5.53.5 without updating companion dev dependencies breaks builds and tests. @sveltejs/vite-plugin-svelte at 1.4.0 was built for Svelte 3 (depends on svelte-hmr@^0.15.1) and is incompatible with Svelte 5's completely rewritten compiler and runtime. @testing-library/svelte at ^3.2.1 uses Svelte 3/4 component instantiation APIs (new Component()) that no longer exist in Svelte 5 — version 5.x of this library is needed. Tests also use component.$set() which was removed in Svelte 5. The vite config alias mapping svelte to svelte/internal is broken since svelte/internal no longer exists in Svelte 5 (replaced by svelte/internal/client).
Additional Locations (1)
f6a1d98 to
d8943a7
Compare
| "@sveltejs/vite-plugin-svelte": "1.4.0", | ||
| "@testing-library/svelte": "^3.2.1", | ||
| "svelte": "3.59.2", | ||
| "svelte": "5.53.5", |
There was a problem hiding this comment.
Svelte 5 removes type import paths breaking build
High Severity
Bumping svelte to 5.53.5 breaks the production type build (build:types:core via tsc). The source files types.ts, config.ts, and preprocessors.ts import PreprocessorGroup from svelte/types/compiler/preprocess and CompileOptions from svelte/types/compiler — these export paths were removed in Svelte 5, where both types are now exported from svelte/compiler. Since tsc resolves types against the devDependency, the type declaration build will fail.
Bumps [svelte](https://github.com/sveltejs/svelte/tree/HEAD/packages/svelte) from 3.59.2 to 5.53.5. - [Release notes](https://github.com/sveltejs/svelte/releases) - [Changelog](https://github.com/sveltejs/svelte/blob/main/packages/svelte/CHANGELOG-pre-5.md) - [Commits](https://github.com/sveltejs/svelte/commits/svelte@5.53.5/packages/svelte) --- updated-dependencies: - dependency-name: svelte dependency-version: 5.53.5 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
d8943a7 to
fd44702
Compare
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
|
closed because we explicitly listed these versions as dev dependencies. Nothing here ships to users |
| "@sveltejs/vite-plugin-svelte": "1.4.0", | ||
| "@testing-library/svelte": "^3.2.1", | ||
| "svelte": "3.59.2", | ||
| "svelte": "5.53.5", |
There was a problem hiding this comment.
Bug: The trackUpdates: true feature silently fails in Svelte 5's default runes mode because it relies on deprecated beforeUpdate/afterUpdate hooks, leading to a loss of performance tracking.
Severity: MEDIUM
Suggested Fix
Update the performance tracking implementation to be compatible with Svelte 5's runes mode, potentially by using a different mechanism than the deprecated beforeUpdate and afterUpdate hooks. Alternatively, if supporting this feature in runes mode is not feasible, explicitly document this limitation and throw a more informative error when trackUpdates: true is used in an unsupported Svelte 5 environment.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: packages/svelte/package.json#L52
Potential issue: The package advertises support for Svelte 5, which defaults to "runes"
mode. However, the performance tracking feature enabled by `trackUpdates: true` relies
on `beforeUpdate()` and `afterUpdate()` lifecycle hooks. These hooks are deprecated in
runes mode and throw an error. The implementation in
`packages/svelte/src/performance.ts` catches this error and suppresses it with only a
debug warning. As a result, for users on Svelte 5, the `trackUpdates` feature will
silently fail to record update performance spans, leading to an unexpected loss of
functionality without a clear error message.
Did we get this right? 👍 / 👎 to inform future reviews.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| "@sveltejs/kit": "^2.53.3", | ||
| "@sveltejs/vite-plugin-svelte": "^3.0.0", | ||
| "svelte": "^4.2.8", | ||
| "svelte": "^5.53.5", |
There was a problem hiding this comment.
Incompatible sveltekit vite-plugin-svelte for Svelte 5
High Severity
Bumping svelte to ^5.53.5 while @sveltejs/vite-plugin-svelte stays at ^3.0.0 (resolves to 3.1.2) creates an incompatibility. Version 3.x of the vite plugin was built for Svelte 4 and does not support Svelte 5's compiler API. This breaks the sveltekit package's dev/test pipeline. The plugin needs to be updated to at least v4+ for Svelte 5 compatibility.


Bumps svelte from 3.59.2 to 5.53.5.
Release notes
Sourced from svelte's releases.
... (truncated)
Changelog
Sourced from svelte's changelog.
... (truncated)
Commits
ed14b49Version Packages (#17802)0df5abcMerge commit from fork0298e97Merge commit from fork96fd3ceVersion Packages (#17786)1b3e660fix: prevent flushed effects from running again (#17787)673a1abfix: set server context after async transformError (#17799)3a28979fix: handle default parameters scope leaks (#17788)fcdc028fix: hydrate if blocks correctly (#17784)97f3ac5Version Packages (#17775)7deedc5fix: render:catchof#awaitblock with correct key (#17769)Maintainer changes
This version was pushed to npm by [GitHub Actions](https://www.npmjs.com/~GitHub Actions), a new releaser for svelte since your current version.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.