feat(core): [Global Attributes 5] Support collections and arrays in log attributes#5124
Open
adinauer wants to merge 3 commits intofix/attribute-integer-type-detectionfrom
Open
feat(core): [Global Attributes 5] Support collections and arrays in log attributes#5124adinauer wants to merge 3 commits intofix/attribute-integer-type-detectionfrom
adinauer wants to merge 3 commits intofix/attribute-integer-type-detectionfrom
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Core
Bug Fixes 🐛
Internal Changes 🔧Deps
🤖 This preview updates automatically when you update the PR. |
Contributor
|
This was referenced Feb 26, 2026
Member
Author
|
PR Stack (Global Attributes):
|
8 tasks
Contributor
Performance metrics 🚀
|
Member
Author
|
@sentry review |
Member
Author
|
cursor review |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable autofix in the Cursor dashboard.
Add arrayAttribute and named array attribute usage to the four attribute tests in ScopesTest (log, count metric, distribution metric, gauge metric) to verify the factory method works end-to-end. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Adds
ARRAYtype support for log attribute type inference. Collections (List,Set, etc.) and arrays passed as attribute values are now correctly typed as"array"instead of falling through to"string"viatoString().Changes:
ARRAYenum value toSentryAttributeTypeinferFrom()to detectCollectionand array typesarrayAttribute()factory method toSentryAttributeThis follows the Python SDK's approach of using
"array"as the attribute type for homogeneous collections.💡 Motivation and Context
Fixes #5074 — Collections passed as log attribute values were being converted to strings, losing their structure. The serialization layer (
JsonObjectSerializer) already handles Collections and arrays as JSON arrays, so only the type enum and inference needed updating.💚 How did you test it?
SentryAttributeTypeTestcoveringList<String>,List<Integer>,Set<Boolean>,String[],int[], empty list, and mixed-type listSentryLogsSerializationTestwith array attribute round-trip (serialize + deserialize)📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Stacked on #5075 (
fix/attribute-integer-type-detection).