feat: add Expo platform icon#238
Open
MattSentry wants to merge 1 commit into
Open
Conversation
Adds an Expo icon (white triangle on Expo's getsentry#20 brand background) to support React Native projects that use the Expo workflow. The icon is registered under the top-level `expo` key as well as `javascript-expo`, matching the naming pattern used for other JS-ecosystem wrappers like `javascript-capacitor`, `javascript-cordova`, and `javascript-ionic`.
Author
|
@elijames-codecov - can you take a peak? wanted to add expo to my LP and it needed to get the svg first |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#000020brand-dark background — at both the standardsvg/(20×20) andsvg_80x80/sizes.expoas a top-level platform key, plus ajavascript-expoalias following the same naming pattern as the other JS-ecosystem wrappers (javascript-capacitor,javascript-cordova,javascript-ionic).src/icons.generated.tsviayarn generate;yarn buildpasses locally.Motivation
Expo is a first-class React Native runtime used by a large slice of mobile Sentry users. Today there's no Expo icon in platformicons, so downstream surfaces (Sentry product UI, marketing pages like
sentry.io/lp/mobile-developers/, docs) either fall back to the React Native icon or ship their own one-off asset. Adding it upstream lets all consumers share a single canonical mark.Test plan
yarn install+yarn buildsucceed locallysrc/icons.generated.tsincludesexpoandexpo_lgimports + Record entries