fix(trace-logs): timestamp_precise is a number, not a string#322
Closed
fix(trace-logs): timestamp_precise is a number, not a string#322
Conversation
Implements the `sentry trace logs` subcommand to view logs associated
with a distributed trace via the dedicated `/organizations/{org}/trace-logs/`
endpoint (org-scoped, queries all projects automatically).
- Adds TraceLog/TraceLogsResponse Zod schemas and types
- Adds `listTraceLogs()` to api-client using region-aware routing
- Adds trace-log formatters to log.ts (batch table + plain markdown)
- New command with flags: --json, --period/-t, --limit/-n, --query/-q, --web/-w
- Positional: `<trace-id>`, `<org> <trace-id>`, or `<org>/<trace-id>`
- 33 tests; 2394 passing total, 0 failures
Replace the 4 trace-log-specific formatter functions with a shared LogLike interface and an includeTrace param on buildLogRowCells. The only real difference was suppressing the trace-ID suffix — both SentryLog and TraceLog carry the same timestamp/severity/message shape. Net: -80 lines, no new abstractions.
# Conflicts: # AGENTS.md
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛Api
Formatters
Other
Internal Changes 🔧Api
🤖 This preview updates automatically when you update the PR. |
The trace-logs API returns timestamp_precise as a nanosecond integer, same as the Explore/Events logs endpoint. The schema incorrectly declared it as z.string() which caused Zod validation failures at runtime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a runtime Zod validation error when running
sentry trace logs. The trace-logs API returnstimestamp_preciseas a nanosecond integer (same as Explore/Events logs), not an ISO string as originally assumed.Changes:
TraceLogSchema.timestamp_precise:z.string()→z.number()Follow-up to #311.