fix: prioritize xcresult output over stderr noise in test results#254
Open
czottmann wants to merge 1 commit intogetsentry:mainfrom
Open
fix: prioritize xcresult output over stderr noise in test results#254czottmann wants to merge 1 commit intogetsentry:mainfrom
czottmann wants to merge 1 commit intogetsentry:mainfrom
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
czottmann
force-pushed
the
fix/stderr-warning-classification
branch
from
c6d1a9d to
ecf2288
Compare
When xcresult parsing succeeds and tests actually ran (totalTestCount > 0), stderr lines are redundant noise (e.g. "multiple matching destinations") and are filtered out. The xcresult summary is placed first in the response. When xcresult reports 0 tests (build failed before tests could run), the xcresult is meaningless and stderr is preserved since it contains the actual compilation errors. Fixes getsentry#231
czottmann
force-pushed
the
fix/stderr-warning-classification
branch
from
ecf2288 to
14eaf6e
Compare
czottmann
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When xcodebuild tests fail, stderr output (e.g. "multiple matching destinations" warnings) was being tagged as errors and displayed prominently, hiding the actual test failure details from the xcresult bundle.
This PR fixes the response assembly in all three test tool paths (
test_macos,test_device,test-common):totalTestCount > 0): xcresult is the authoritative source. Stderr lines are filtered out as redundant noise, and the xcresult summary is placed first in the response.totalTestCount == 0): xcresult is meaningless (empty summary). Stderr is preserved since it contains the actual compilation errors.No changes to
build-utils.tsor stderr capture/classification logic.Fixes #231
Test plan