Allow setting JDK path via a java.home JSON setting.#234
Open
brown wants to merge 1 commit intogeorgewfraser:masterfrom
Open
Allow setting JDK path via a java.home JSON setting.#234brown wants to merge 1 commit intogeorgewfraser:masterfrom
brown wants to merge 1 commit intogeorgewfraser:masterfrom
Conversation
brown
force-pushed
the
allow-setting-java-home
branch
3 times, most recently
from
7f92e45 to
e77a0c4
Compare
antonkesy
approved these changes
May 2, 2023
Owner
|
Can you add a test @brown ? |
Update the documentation.
brown
force-pushed
the
allow-setting-java-home
branch
from
e77a0c4 to
8b69428
Compare
Contributor
Author
|
I would like to add a test, but it doesn't look straightforward. Please suggest an approach you would be happy with. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the language server always infers the location of the JDK, either from JAVA_HOME or by searching in various directories that depend on the operating system.
This pull request adds the ability to set the JDK location explicitly via JSON.