Skip to content

[codex] Refactor search pipeline orchestration#254

Merged
ewlarson merged 1 commit into
developfrom
feature/search-pipeline-refactor
May 22, 2026
Merged

[codex] Refactor search pipeline orchestration#254
ewlarson merged 1 commit into
developfrom
feature/search-pipeline-refactor

Conversation

@ewlarson
Copy link
Copy Markdown
Contributor

@ewlarson ewlarson commented May 22, 2026

Summary

  • Extract the Elasticsearch search request path into explicit orchestration layers: params, facet handling, geo filters, query building, execution, and response building.
  • Preserve the existing search_resources public signature while moving the long in-function pipeline into smaller behavior-preserving collaborators.
  • Fix two test-suite blockers found while validating locally: the WMS/WMTS migration seed swap and thumbnail alias redirects that pointed at missing cached images.

Why

This starts recommendation two from the pre-v1.0 review: split the search pipeline into understandable layers without changing response behavior. The goal is to make follow-up search work safer by isolating query construction, execution, facet aggregation, and response assembly.

Validation

  • make lint
  • make format
  • COMPOSE_PROJECT_NAME=data-api WALLCLOCK_TIMEOUT_SECONDS=360 make test

Result: 1751 passed, 129 skipped, 1 xpassed; coverage 60.64%.

Comment thread backend/app/elasticsearch/search.py Fixed
Comment thread backend/app/elasticsearch/search.py Fixed
Comment thread backend/app/elasticsearch/search.py Fixed
@ewlarson ewlarson force-pushed the feature/search-pipeline-refactor branch from 89441f6 to 6899da1 Compare May 22, 2026 23:24
@ewlarson ewlarson force-pushed the feature/search-pipeline-refactor branch from 6899da1 to fc09cfe Compare May 22, 2026 23:31
@ewlarson ewlarson marked this pull request as ready for review May 22, 2026 23:55
@ewlarson ewlarson merged commit 299aebe into develop May 22, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant