[codex] Refactor search pipeline orchestration#254
Merged
Conversation
89441f6 to
6899da1
Compare
6899da1 to
fc09cfe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
search_resourcespublic signature while moving the long in-function pipeline into smaller behavior-preserving collaborators.Why
This starts recommendation two from the pre-v1.0 review: split the search pipeline into understandable layers without changing response behavior. The goal is to make follow-up search work safer by isolating query construction, execution, facet aggregation, and response assembly.
Validation
make lintmake formatCOMPOSE_PROJECT_NAME=data-api WALLCLOCK_TIMEOUT_SECONDS=360 make testResult:
1751 passed, 129 skipped, 1 xpassed; coverage60.64%.