fix(tools): correct args validation in langchain tool wrapper#761
Open
markstur wants to merge 1 commit intogenerative-computing:mainfrom
Open
fix(tools): correct args validation in langchain tool wrapper#761markstur wants to merge 1 commit intogenerative-computing:mainfrom
markstur wants to merge 1 commit intogenerative-computing:mainfrom
Conversation
Fixed logic error in MelleaTool.from_langchain() where the condition `if args is not None or len(args) != 0:` was always True, causing false positive warnings on every tool call. Changed to `if args:` which correctly checks for non-empty tuples, since *args is always a tuple (never None) in Python. Added test_from_langchain_args_handling() to verify: - No warning when called with kwargs only (normal case) - Warning logged when positional args passed (edge case) Closes: generative-computing#760 Signed-off-by: Mark Sturdevant <mark.sturdevant@ibm.com>
Contributor
|
The PR description has been updated. Please fill out the template for your PR to be reviewed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Misc PR
Type of PR
Description
Fixed logic error in MelleaTool.from_langchain() where the condition
if args is not None or len(args) != 0:was always True, causing false positive warnings on every tool call.Changed to
if args:which correctly checks for non-empty tuples, since *args is always a tuple (never None) in Python.Added test_from_langchain_args_handling() to verify:
Testing