Update the benchmark config, and fix the block size propogation#808
Open
googlyrahman wants to merge 3 commits intofsspec:mainfrom
Open
Update the benchmark config, and fix the block size propogation#808googlyrahman wants to merge 3 commits intofsspec:mainfrom
googlyrahman wants to merge 3 commits intofsspec:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #808 +/- ##
==========================================
+ Coverage 79.55% 79.81% +0.26%
==========================================
Files 16 16
Lines 3042 3042
==========================================
+ Hits 2420 2428 +8
+ Misses 622 614 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zhixiangli
reviewed
Apr 15, 2026
Collaborator
Author
|
@ankitaluthra1 can you review this? |
jasha26
reviewed
Apr 15, 2026
| pattern: "seq" | ||
| processes: [16, 48] | ||
| processes: [1, 16, 48] | ||
| files: 1 |
Collaborator
There was a problem hiding this comment.
we don't need to mention this as it's default value
jasha26
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update and simplify the read configuration. This ensures we accurately capture the performance gains of prefetching. Small files finish reading before the prefetcher has a chance to provide any real benefit.
Fix the block size propagation issue. A previous PR separated the block size and chunk size parameters but missed updating the test_read file. Because of that, the block size argument was being ignored entirely. This ensures the parameter is passed down correctly.