Fix closing contexts of tar and zip files and add test 3.14t in CI#2012
Merged
martindurant merged 2 commits intofsspec:masterfrom Apr 14, 2026
Merged
Fix closing contexts of tar and zip files and add test 3.14t in CI#2012martindurant merged 2 commits intofsspec:masterfrom
martindurant merged 2 commits intofsspec:masterfrom
Conversation
ariostas
force-pushed
the
fix_file_closing
branch
from
8a60662 to
443c6b9
Compare
ariostas
force-pushed
the
fix_file_closing
branch
from
443c6b9 to
20c64f1
Compare
|
is there a particular reason fsspec is not being tested in 3.14t atm @martindurant ? |
Member
Only that no one has added it - feel free to do so. |
|
Should it be added here and turn this into a 3.14t testing/compatibility PR? |
Member
|
Yes, let's try |
ariostas
force-pushed
the
fix_file_closing
branch
2 times, most recently
from
a5e7b40 to
9ab084c
Compare
ariostas
force-pushed
the
fix_file_closing
branch
from
9ab084c to
51612ff
Compare
Contributor
Author
|
I made some final tweaks and tested the CI in my fork and everything works: https://github.com/ariostas/filesystem_spec/actions/runs/24408370609/job/71297942303 |
ariostas
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into an issue while testing Uproot with Python 3.14t in this PR scikit-hep/uproot5#1619. Since garbage collection on freethreaded mode is a bit looser, it doesn't end up immediately closing contexts when an object is dropped, and you end up with warnings like
ResourceWarning: unclosed file .... To solve this, we can explicitly call__exit__in__del__. I also addedclose()to the tar implementation, since it was missing.