fix: metadata build target — gawk dependency, missing redirect, missing HEAD#508
Open
braceyourself wants to merge 1 commit intoforge-ext:mainfrom
Open
fix: metadata build target — gawk dependency, missing redirect, missing HEAD#508braceyourself wants to merge 1 commit intoforge-ext:mainfrom
braceyourself wants to merge 1 commit intoforge-ext:mainfrom
Conversation
…ng HEAD `make build` fails on systems where `awk` is mawk (Ubuntu, Debian, and derivatives) because the `metadata` target uses `awk -i inplace`, a gawk-only extension. Make aborts on the error, leaving `lib/prefs/metadata.js` truncated — which crashes the preferences dialog: SyntaxError: expected expression, got end of script Two additional bugs in the same target: - `git shortlog -sne` output goes to stdout instead of the file (missing `>>`), so the developers array is always empty even on gawk systems where the build succeeds - Without an explicit `HEAD` argument, `git shortlog` reads from stdin in non-interactive environments (CI, makepkg, rpmbuild), producing no output Replaces gawk-only `awk -i inplace` with portable `sed -i -E`. Redirects shortlog output to the file with explicit `HEAD`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Building from source on Ubuntu/Debian produces a broken preferences dialog because the
metadataMakefile target usesawk -i inplace, which is a gawk-only feature — these distros ship mawk as the defaultawk. Make aborts on the error, leavinglib/prefs/metadata.jstruncated:Also fixes two other bugs in the same target that made the developers list empty on all distros:
git shortlog -sneoutput was going to stdout instead of the file (missing>>)git shortlogwithout explicitHEADreads from stdin in non-interactive builds (CI, makepkg, rpmbuild), producing no outputChanges
awk -i inplacewith portablesed -i -EHEAD