Specify that widget rebuilds is only available in debug-mode#9733
Open
Bingtagui404 wants to merge 1 commit intoflutter:masterfrom
Open
Specify that widget rebuilds is only available in debug-mode#9733Bingtagui404 wants to merge 1 commit intoflutter:masterfrom
Bingtagui404 wants to merge 1 commit intoflutter:masterfrom
Conversation
When running an app in profile-mode, the Performance panel previously showed a disabled "Count widget builds" checkbox without explaining why it was disabled. This change checks whether the connected app is a profile build using `isProfileBuildNow`. When it is, the checkbox and clear button are removed and replaced with a message explaining that widget rebuild counts are only available in debug-mode. Fixes flutter#9730
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9730
Description
When running an app in profile-mode, the Performance panel previously showed a disabled "Count widget builds" checkbox without explaining why it was disabled. The
trackRebuildDirtyWidgetsservice extension relies ondebugOnRebuildDirtyWidget, which is only available in debug-mode.This change checks whether the connected app is a profile build using
connectedApp?.isProfileBuildNow(consistent with the approach inmore_debugging_options.dart). When it is a profile build, the checkbox and clear button are removed and replaced with a centered message:When running in debug-mode, the existing checkbox and rebuild stats table remain unchanged.
Changes
packages/devtools_app/lib/src/screens/performance/panes/rebuild_stats/rebuild_stats.dart: Added an early return in_RebuildStatsViewState.build()that shows an informational message when the connected app is a profile build.