Add support for searching within the log details view#9712
Merged
kenzieschmoll merged 8 commits intoflutter:masterfrom Mar 18, 2026
Merged
Add support for searching within the log details view#9712kenzieschmoll merged 8 commits intoflutter:masterfrom
kenzieschmoll merged 8 commits intoflutter:masterfrom
Conversation
kenzieschmoll
requested review from
elliette and
srawlins
and removed request for
a team
elliette
reviewed
Mar 14, 2026
| builder: (context, values, _) { | ||
| final theme = Theme.of(context); | ||
|
|
||
| final matches = values[0] as List<LogDetailsMatch>; |
Member
There was a problem hiding this comment.
Consider pulling some of this into a shared helper that can be used here and in the codeview highlighter - looks like there is some shared logic here but not sure how much work it would be to refactor
Member
Author
There was a problem hiding this comment.
The codeview highlighter highlights text across multiple text spans and this highlight logic is for plain text, so there isn't a ton that can be pulled out to be shared logic. But I did create a utility SearchHighlighter so that both of these can be used in other parts of DevTools, and added test coverage.
elliette
approved these changes
Mar 14, 2026
srawlins
approved these changes
Mar 14, 2026
Contributor
srawlins
left a comment
srawlins
left a comment
There was a problem hiding this comment.
Everything looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability to search in the log details view.
This PR only adds this for the raw text details view since adding search functionality to the expandable JSON viewer would require a more complicated refactor of that widget, and the benefit does not justify the cost.
Fixes #9559