fix(deps): update tsam bounds after yanked releases#622
Conversation
tsam 3.0.0 and 3.1.0 were yanked from PyPI. Update: - full: >= 3.1.1, < 4 (was >= 3.0.0, < 4, != 3.1.0) - dev: ==3.1.2 (was ==3.0.0) All 258 clustering tests pass on 3.1.2. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
📝 WalkthroughWalkthroughThis pull request updates the tsam time-series library dependency constraints in both CHANGELOG.md and pyproject.toml. The version bounds change from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
tsam 3.0.0 and 3.1.0 were yanked from PyPI. Update: - full: >= 3.1.1, < 4 (was >= 3.0.0, < 4, != 3.1.0) - dev: ==3.1.2 (was ==3.0.0) Fold dependency note into 6.1.0 release notes. All 258 clustering tests pass on 3.1.2. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
🧹 Nitpick comments (1)
pyproject.toml (1)
66-66: Add CI validation for the minimum supportedtsamversion.
fullpermitstsam >= 3.1.1, but CI only validates againsttsam==3.1.2(via.[dev]). Either add a test matrix entry fortsam==3.1.1or raise the lower bound to>=3.1.2to match tested coverage.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@pyproject.toml` at line 66, The dependency line "tsam >= 3.1.1, < 4" in pyproject.toml declares 3.1.1 as the minimum but CI only tests with tsam==3.1.2 via the dev extras; either add a CI matrix entry that runs the test suite against tsam==3.1.1 or change the pyproject.toml constraint to "tsam >= 3.1.2, < 4" so the declared minimum matches what CI validates—update the dependency in pyproject.toml or extend the CI test matrix accordingly and rerun CI to confirm consistency.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@pyproject.toml`:
- Line 66: The dependency line "tsam >= 3.1.1, < 4" in pyproject.toml declares
3.1.1 as the minimum but CI only tests with tsam==3.1.2 via the dev extras;
either add a CI matrix entry that runs the test suite against tsam==3.1.1 or
change the pyproject.toml constraint to "tsam >= 3.1.2, < 4" so the declared
minimum matches what CI validates—update the dependency in pyproject.toml or
extend the CI test matrix accordingly and rerun CI to confirm consistency.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 8e60ba6c-431a-43c5-a6b5-1217039bf04f
📒 Files selected for processing (2)
CHANGELOG.mdpyproject.toml
Summary
fullbounds:>= 3.1.1, < 4(was>= 3.0.0, < 4, != 3.1.0)devpin:==3.1.2(was==3.0.0)Test plan
tests/test_clustering/— 245 tests passedtests/test_math/test_clustering.py— 13 tests passed🤖 Generated with Claude Code
Summary by CodeRabbit