-
Notifications
You must be signed in to change notification settings - Fork 137
Limited Use Tokens in Functions #1840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AustinBenoit
wants to merge
12
commits into
main
Choose a base branch
from
limiteduse-all
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
62255d7
Feat: add in limited use tokens to functions
AustinBenoit e9a0944
Update release notes
AustinBenoit de71bc1
Add test and callable reference internal for options
AustinBenoit 0a63d01
Fix docs and formating
AustinBenoit 3416930
Fix builder naming
AustinBenoit ad25d85
Add in the app enabled test for th e
AustinBenoit f7af592
Merge branch 'main' into limiteduse-all
AustinBenoit 7824292
Add copyright
AustinBenoit 5f30cf3
Formating fix
AustinBenoit 55778cd
Fix typo in functions_ios.mm selector for limited use tokens
AustinBenoit 2676f80
Fix token spelling
AustinBenoit 6ef3eee
Fix typo in functions_ios.mm and add app_check dependency to function…
AustinBenoit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| { | ||
| "projects": { | ||
| "default": "functions-test-app" | ||
| } | ||
| } |
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this can be removed too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| { | ||
| "functions": { | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| // Copyright 2026 Google Inc. All rights reserved. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
|
|
||
| /** | ||
| * Import function triggers from their respective submodules: | ||
| * | ||
| * const {onCall} = require("firebase-functions/v1/https"); // wait, V1 doesn't have /v1/https | ||
| * | ||
| * See a full list of supported triggers at https://firebase.google.com/docs/functions | ||
| */ | ||
|
|
||
| const functions = require("firebase-functions"); | ||
|
|
||
| // Creates a function that consumes limited-use App Check tokens | ||
| exports.addtwowithlimiteduse = functions.runWith({ | ||
| enforceAppCheck: true, | ||
| consumeAppCheckToken: true, | ||
| maxInstances: 10 // Setting maxInstances the V1 way | ||
| }).https.onCall((data, context) => { | ||
| // context.app will be defined if a valid App Check token was provided | ||
| if (context.app === undefined) { | ||
| throw new functions.https.HttpsError( | ||
| 'failed-precondition', | ||
| 'The function must be called from an App Check verified app.'); | ||
| } | ||
|
|
||
| const firstNumber = data.firstNumber; | ||
| const secondNumber = data.secondNumber; | ||
|
|
||
| if (firstNumber === undefined || secondNumber === undefined) { | ||
| throw new functions.https.HttpsError('invalid-argument', 'The function must be called with "firstNumber" and "secondNumber".'); | ||
| } | ||
|
|
||
| return { | ||
| firstNumber: firstNumber, | ||
| secondNumber: secondNumber, | ||
| operator: '+', | ||
| operationResult: Number(firstNumber) + Number(secondNumber), | ||
| }; | ||
| }); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should remove this too