Skip to content

test: improve test coverage#1356

Merged
jescalada merged 37 commits intofinos:mainfrom
jescalada:improve-test-coverage
Mar 5, 2026
Merged

test: improve test coverage#1356
jescalada merged 37 commits intofinos:mainfrom
jescalada:improve-test-coverage

Conversation

@jescalada
Copy link
Contributor

@jescalada jescalada commented Jan 18, 2026

Improves test coverage on route files and MongoDB handlers.

@netlify
Copy link

netlify bot commented Jan 18, 2026

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 3e9059c
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/696c81ab0cbec100088dae6b

@netlify
Copy link

netlify bot commented Jan 18, 2026

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 698e39f
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/69a853e34441f800087e00df

@codecov
Copy link

codecov bot commented Jan 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.01%. Comparing base (3c43652) to head (698e39f).
⚠️ Report is 38 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1356      +/-   ##
==========================================
+ Coverage   81.77%   90.01%   +8.24%     
==========================================
  Files          67       67              
  Lines        4769     4769              
  Branches      827      885      +58     
==========================================
+ Hits         3900     4293     +393     
+ Misses        853      458     -395     
- Partials       16       18       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jescalada jescalada marked this pull request as ready for review January 26, 2026 07:59
@jescalada jescalada requested review from a team and kriswest January 26, 2026 07:59
@jescalada jescalada self-assigned this Jan 26, 2026
@jescalada jescalada changed the title test: improve push routes coverage test: improve test coverage Jan 28, 2026
@fabiovincenzi fabiovincenzi mentioned this pull request Jan 30, 2026
21 tasks
@fabiovincenzi
Copy link
Contributor

Great work! Thanks @jescalada , just a few minor cleanup items.

@kriswest kriswest requested a review from andypols February 23, 2026 16:44
Copy link
Contributor

@andypols andypols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - a much needed improvement to the code. Only one suggestion to make a test intent clearer.

Copy link
Contributor

@dcoric dcoric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great coverage improvement overall. Added small comments for double teardown and to reduce flakiness if an assertion fails mid-test.

@jescalada
Copy link
Contributor Author

jescalada commented Mar 4, 2026

@andypols Fixed the coverage dip and failing/misleading tests; should be ready to merge!

@kriswest kriswest requested a review from andypols March 5, 2026 07:53
@kriswest
Copy link
Contributor

kriswest commented Mar 5, 2026

@andypols you'll have to re-review before this can merge (as you have write perms and requested changes)

andypols

This comment was marked as resolved.

Copy link
Contributor

@andypols andypols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - approved for merge

@jescalada jescalada merged commit ac353de into finos:main Mar 5, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants