docs: multiplicity v2 incremental re-implementation plan#489
Merged
Conversation
PR #480 was reverted due to a Scalar::Util version parsing error that broke Moo tests. Root cause: regex timeout executor threads had no PerlRuntime bound via ThreadLocal. This plan breaks the original 96-file monolithic PR into 16 independently testable phases, each with its own validation gate. Generated with [Devin](https://cli.devin.ai/docs) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a detailed incremental re-implementation plan for multiplicity after PR #480 was reverted (PR #487).
Root cause of the revert
RuntimeRegex.matchRegexWithTimeout()spawns executor threads for alarm-based regex timeout. After the multiplicity migration, these threads had no PerlRuntime bound via ThreadLocal, causingIllegalStateExceptionwhen accessing per-runtime regex state. This brokeCPAN::Module::parse_version->MM->parse_version('jar:PERL5LIB/Scalar/Util.pm')-> Moo tests.What this plan changes
Instead of one 96-file PR, the work is broken into 16 independently testable phases:
Each phase has its own validation gate:
make+make test-all+ Scalar::Util version check.Reference branches
feature/multiplicity— original implementation (diff target for each phase)feature/multiplicity-opt— performance optimizationsfeature/multiplicity-v2— post-revert fixesTest plan
makepassesGenerated with Devin