Skip to content

Improved default PETSc options behaviour#1077

Merged
RemDelaporteMathurin merged 6 commits intofenicsxfrom
default_petsc_opts
Mar 27, 2026
Merged

Improved default PETSc options behaviour#1077
RemDelaporteMathurin merged 6 commits intofenicsxfrom
default_petsc_opts

Conversation

@RemDelaporteMathurin
Copy link
Copy Markdown
Collaborator

@RemDelaporteMathurin RemDelaporteMathurin commented Feb 25, 2026

Description

Summary

This PR refactors the way we treat petsc options.

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🔨 Code refactoring (no functional changes, no API changes)
  • 📝 Documentation update
  • ✅ Test update (adding missing tests or correcting existing tests)
  • 🔧 Build/CI configuration change

Testing

  • All existing tests pass locally (pytest)
  • I have added new tests that prove my fix is effective or that my feature works

Code Quality Checklist

  • My code follows the code style of this project (Ruff formatted: ruff format .)
  • My code passes linting checks (ruff check .)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

Documentation

  • I have updated the documentation accordingly (if applicable)
  • I have added docstrings to new functions/classes following the project conventions

Breaking Changes

Screenshots/Examples

Additional Notes

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 25, 2026

Codecov Report

❌ Patch coverage is 81.81818% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.94%. Comparing base (4b6a9d1) to head (aa0e7c5).
⚠️ Report is 7 commits behind head on fenicsx.

Files with missing lines Patch % Lines
src/festim/problem.py 80.95% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           fenicsx    #1077      +/-   ##
===========================================
+ Coverage    94.84%   94.94%   +0.09%     
===========================================
  Files           44       44              
  Lines         3220     3222       +2     
===========================================
+ Hits          3054     3059       +5     
+ Misses         166      163       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RemDelaporteMathurin
Copy link
Copy Markdown
Collaborator Author

@jhdark can we merge/review this?

@RemDelaporteMathurin RemDelaporteMathurin merged commit ad0043c into fenicsx Mar 27, 2026
15 of 18 checks passed
@RemDelaporteMathurin RemDelaporteMathurin deleted the default_petsc_opts branch March 27, 2026 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants