Moved OpenAL code into Core shared code folder.#68
Merged
fbraz3 merged 5 commits intofbraz3:mainfrom Apr 7, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the OpenAL audio backend so it lives under Core/GameEngineDevice/ as shared cross-game device code, and updates both Generals and Zero Hour game-device builds to consume it through the Core CMake interface targets.
Changes:
- Move OpenALAudioDevice headers/sources into
Core/GameEngineDeviceand expose them viacorei_gameenginedevice_privatewhenSAGE_USE_OPENALis enabled. - Update
GeneralsMD/Code/GameEngineDeviceandGenerals/Code/GameEngineDeviceCMakeLists to stop listing OpenAL/FFmpeg sources directly and rely on Core-provided sources/includes. - Update the dev diary entry for 2026-03-31 to reflect the refactor.
Reviewed changes
Copilot reviewed 4 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| signal-desktop-keyring.gpg | Adds a binary GPG keyring file at repo root (not part of OpenAL refactor). |
| GeneralsMD/Code/GameEngineDevice/CMakeLists.txt | Removes duplicate OpenAL source listing; relies on Core interface sources when SAGE_USE_OPENAL is enabled. |
| Generals/Code/GameEngineDevice/CMakeLists.txt | Removes GeneralsMD absolute-path OpenAL source usage; relies on Core interface sources/includes. |
| docs/DEV_BLOG/2026-03-DIARY.md | Rewrites the 2026-03-31 entry to describe the OpenAL move/refactor. |
| Core/GameEngineDevice/Source/OpenALAudioDevice/OpenALAudioStream.cpp | Adds streaming source/buffer management implementation under Core. |
| Core/GameEngineDevice/Source/OpenALAudioDevice/OpenALAudioManager.cpp | Adds the OpenAL audio manager implementation under Core (large file moved in). |
| Core/GameEngineDevice/Source/OpenALAudioDevice/OpenALAudioCache.h | Adds the OpenAL audio file cache header under Core. |
| Core/GameEngineDevice/Source/OpenALAudioDevice/OpenALAudioCache.cpp | Adds the OpenAL audio file cache implementation under Core. |
| Core/GameEngineDevice/Include/OpenALAudioDevice/OpenALAudioStream.h | Adds the OpenAL stream public header under Core. |
| Core/GameEngineDevice/Include/OpenALAudioDevice/OpenALAudioManager.h | Adds the OpenAL manager public header under Core. |
| Core/GameEngineDevice/CMakeLists.txt | Wires OpenALAudioDevice sources/includes into Core interface targets and conditionally provides FFmpegFile.cpp. |
fbraz3
requested changes
Apr 1, 2026
fbraz3
approved these changes
Apr 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.