Skip to content

Moved OpenAL code into Core shared code folder.#68

Merged
fbraz3 merged 5 commits intofbraz3:mainfrom
DMJC:OpenAL-Refactor
Apr 7, 2026
Merged

Moved OpenAL code into Core shared code folder.#68
fbraz3 merged 5 commits intofbraz3:mainfrom
DMJC:OpenAL-Refactor

Conversation

@DMJC
Copy link
Copy Markdown

@DMJC DMJC commented Apr 1, 2026

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the OpenAL audio backend so it lives under Core/GameEngineDevice/ as shared cross-game device code, and updates both Generals and Zero Hour game-device builds to consume it through the Core CMake interface targets.

Changes:

  • Move OpenALAudioDevice headers/sources into Core/GameEngineDevice and expose them via corei_gameenginedevice_private when SAGE_USE_OPENAL is enabled.
  • Update GeneralsMD/Code/GameEngineDevice and Generals/Code/GameEngineDevice CMakeLists to stop listing OpenAL/FFmpeg sources directly and rely on Core-provided sources/includes.
  • Update the dev diary entry for 2026-03-31 to reflect the refactor.

Reviewed changes

Copilot reviewed 4 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
signal-desktop-keyring.gpg Adds a binary GPG keyring file at repo root (not part of OpenAL refactor).
GeneralsMD/Code/GameEngineDevice/CMakeLists.txt Removes duplicate OpenAL source listing; relies on Core interface sources when SAGE_USE_OPENAL is enabled.
Generals/Code/GameEngineDevice/CMakeLists.txt Removes GeneralsMD absolute-path OpenAL source usage; relies on Core interface sources/includes.
docs/DEV_BLOG/2026-03-DIARY.md Rewrites the 2026-03-31 entry to describe the OpenAL move/refactor.
Core/GameEngineDevice/Source/OpenALAudioDevice/OpenALAudioStream.cpp Adds streaming source/buffer management implementation under Core.
Core/GameEngineDevice/Source/OpenALAudioDevice/OpenALAudioManager.cpp Adds the OpenAL audio manager implementation under Core (large file moved in).
Core/GameEngineDevice/Source/OpenALAudioDevice/OpenALAudioCache.h Adds the OpenAL audio file cache header under Core.
Core/GameEngineDevice/Source/OpenALAudioDevice/OpenALAudioCache.cpp Adds the OpenAL audio file cache implementation under Core.
Core/GameEngineDevice/Include/OpenALAudioDevice/OpenALAudioStream.h Adds the OpenAL stream public header under Core.
Core/GameEngineDevice/Include/OpenALAudioDevice/OpenALAudioManager.h Adds the OpenAL manager public header under Core.
Core/GameEngineDevice/CMakeLists.txt Wires OpenALAudioDevice sources/includes into Core interface targets and conditionally provides FFmpegFile.cpp.

Comment thread docs/DEV_BLOG/2026-03-DIARY.md Outdated
Comment thread signal-desktop-keyring.gpg Outdated
@fbraz3 fbraz3 force-pushed the OpenAL-Refactor branch from 1a1b5e9 to 3238bda Compare April 4, 2026 19:23
@fbraz3 fbraz3 merged commit 4b63989 into fbraz3:main Apr 7, 2026
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants