Skip to content

Make IRuntime public #56770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zoontek wants to merge 2 commits into from
Closed

Make IRuntime public #56770

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa23775
Make IRuntime destructor public
zoontek May 11, 2026
a9e883b
Update Cxx snapshots
zoontek May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/react-native/ReactCommon/jsi/jsi/jsi.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -680,7 +680,6 @@ class JSI_EXPORT IRuntime : public ICast {
/// property of a JS string.
virtual size_t length(const String& str) = 0;

protected:
virtual ~IRuntime() = default;
};

Expand Down
4 changes: 2 additions & 2 deletions scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11859,7 +11859,6 @@ class facebook::jsi::HostObject {
}

class facebook::jsi::IRuntime : public facebook::jsi::ICast {
protected virtual ~IRuntime() = default;
public static constexpr facebook::jsi::UUID uuid;
public virtual ScopeState* pushScope() = 0;
public virtual bool bigintIsInt64(const facebook::jsi::BigInt&) = 0;
Expand Down Expand Up @@ -11969,6 +11968,7 @@ class facebook::jsi::IRuntime : public facebook::jsi::ICast {
public virtual void setRuntimeData(const facebook::jsi::UUID& dataUUID, const std::shared_ptr<void>& data) = 0;
public virtual void setRuntimeDataImpl(const facebook::jsi::UUID& dataUUID, const void* data, void(*)(const void* data) deleter) = 0;
public virtual void setValueAtIndexImpl(const facebook::jsi::Array&, size_t i, const facebook::jsi::Value& value) = 0;
public virtual ~IRuntime() = default;
}

struct facebook::jsi::IRuntime::PointerValue {
Expand Down Expand Up @@ -13668,4 +13668,4 @@ struct std::hash<facebook::react::jsinspector_modern::UniqueMonostate<key>> {
}


void YGJNIVanilla::registerNatives(JNIEnv* env);
void YGJNIVanilla::registerNatives(JNIEnv* env);
4 changes: 2 additions & 2 deletions scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11715,7 +11715,6 @@ class facebook::jsi::HostObject {
}

class facebook::jsi::IRuntime : public facebook::jsi::ICast {
protected virtual ~IRuntime() = default;
public static constexpr facebook::jsi::UUID uuid;
public virtual ScopeState* pushScope() = 0;
public virtual bool bigintIsInt64(const facebook::jsi::BigInt&) = 0;
Expand Down Expand Up @@ -11825,6 +11824,7 @@ class facebook::jsi::IRuntime : public facebook::jsi::ICast {
public virtual void setRuntimeData(const facebook::jsi::UUID& dataUUID, const std::shared_ptr<void>& data) = 0;
public virtual void setRuntimeDataImpl(const facebook::jsi::UUID& dataUUID, const void* data, void(*)(const void* data) deleter) = 0;
public virtual void setValueAtIndexImpl(const facebook::jsi::Array&, size_t i, const facebook::jsi::Value& value) = 0;
public virtual ~IRuntime() = default;
}

struct facebook::jsi::IRuntime::PointerValue {
Expand Down Expand Up @@ -13524,4 +13524,4 @@ struct std::hash<facebook::react::jsinspector_modern::UniqueMonostate<key>> {
}


void YGJNIVanilla::registerNatives(JNIEnv* env);
void YGJNIVanilla::registerNatives(JNIEnv* env);
4 changes: 2 additions & 2 deletions scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14077,7 +14077,6 @@ class facebook::jsi::HostObject {
}

class facebook::jsi::IRuntime : public facebook::jsi::ICast {
protected virtual ~IRuntime() = default;
public static constexpr facebook::jsi::UUID uuid;
public virtual ScopeState* pushScope() = 0;
public virtual bool bigintIsInt64(const facebook::jsi::BigInt&) = 0;
Expand Down Expand Up @@ -14187,6 +14186,7 @@ class facebook::jsi::IRuntime : public facebook::jsi::ICast {
public virtual void setRuntimeData(const facebook::jsi::UUID& dataUUID, const std::shared_ptr<void>& data) = 0;
public virtual void setRuntimeDataImpl(const facebook::jsi::UUID& dataUUID, const void* data, void(*)(const void* data) deleter) = 0;
public virtual void setValueAtIndexImpl(const facebook::jsi::Array&, size_t i, const facebook::jsi::Value& value) = 0;
public virtual ~IRuntime() = default;
}

struct facebook::jsi::IRuntime::PointerValue {
Expand Down Expand Up @@ -16258,4 +16258,4 @@ class FB::LazyVector {
public using reference = T;
public using size_type = std::int32_t;
public using value_type = T;
}
}
4 changes: 2 additions & 2 deletions scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13943,7 +13943,6 @@ class facebook::jsi::HostObject {
}

class facebook::jsi::IRuntime : public facebook::jsi::ICast {
protected virtual ~IRuntime() = default;
public static constexpr facebook::jsi::UUID uuid;
public virtual ScopeState* pushScope() = 0;
public virtual bool bigintIsInt64(const facebook::jsi::BigInt&) = 0;
Expand Down Expand Up @@ -14053,6 +14052,7 @@ class facebook::jsi::IRuntime : public facebook::jsi::ICast {
public virtual void setRuntimeData(const facebook::jsi::UUID& dataUUID, const std::shared_ptr<void>& data) = 0;
public virtual void setRuntimeDataImpl(const facebook::jsi::UUID& dataUUID, const void* data, void(*)(const void* data) deleter) = 0;
public virtual void setValueAtIndexImpl(const facebook::jsi::Array&, size_t i, const facebook::jsi::Value& value) = 0;
public virtual ~IRuntime() = default;
}

struct facebook::jsi::IRuntime::PointerValue {
Expand Down Expand Up @@ -16124,4 +16124,4 @@ class FB::LazyVector {
public using reference = T;
public using size_type = std::int32_t;
public using value_type = T;
}
}
4 changes: 2 additions & 2 deletions scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8894,7 +8894,6 @@ class facebook::jsi::HostObject {
}

class facebook::jsi::IRuntime : public facebook::jsi::ICast {
protected virtual ~IRuntime() = default;
public static constexpr facebook::jsi::UUID uuid;
public virtual ScopeState* pushScope() = 0;
public virtual bool bigintIsInt64(const facebook::jsi::BigInt&) = 0;
Expand Down Expand Up @@ -9004,6 +9003,7 @@ class facebook::jsi::IRuntime : public facebook::jsi::ICast {
public virtual void setRuntimeData(const facebook::jsi::UUID& dataUUID, const std::shared_ptr<void>& data) = 0;
public virtual void setRuntimeDataImpl(const facebook::jsi::UUID& dataUUID, const void* data, void(*)(const void* data) deleter) = 0;
public virtual void setValueAtIndexImpl(const facebook::jsi::Array&, size_t i, const facebook::jsi::Value& value) = 0;
public virtual ~IRuntime() = default;
}

struct facebook::jsi::IRuntime::PointerValue {
Expand Down Expand Up @@ -10612,4 +10612,4 @@ struct std::hash<facebook::react::jsinspector_modern::ExecutionContextSelector>
template <size_t key>
struct std::hash<facebook::react::jsinspector_modern::UniqueMonostate<key>> {
public size_t operator()(const facebook::react::jsinspector_modern::UniqueMonostate<key>&) const noexcept;
}
}
4 changes: 2 additions & 2 deletions scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8885,7 +8885,6 @@ class facebook::jsi::HostObject {
}

class facebook::jsi::IRuntime : public facebook::jsi::ICast {
protected virtual ~IRuntime() = default;
public static constexpr facebook::jsi::UUID uuid;
public virtual ScopeState* pushScope() = 0;
public virtual bool bigintIsInt64(const facebook::jsi::BigInt&) = 0;
Expand Down Expand Up @@ -8995,6 +8994,7 @@ class facebook::jsi::IRuntime : public facebook::jsi::ICast {
public virtual void setRuntimeData(const facebook::jsi::UUID& dataUUID, const std::shared_ptr<void>& data) = 0;
public virtual void setRuntimeDataImpl(const facebook::jsi::UUID& dataUUID, const void* data, void(*)(const void* data) deleter) = 0;
public virtual void setValueAtIndexImpl(const facebook::jsi::Array&, size_t i, const facebook::jsi::Value& value) = 0;
public virtual ~IRuntime() = default;
}

struct facebook::jsi::IRuntime::PointerValue {
Expand Down Expand Up @@ -10603,4 +10603,4 @@ struct std::hash<facebook::react::jsinspector_modern::ExecutionContextSelector>
template <size_t key>
struct std::hash<facebook::react::jsinspector_modern::UniqueMonostate<key>> {
public size_t operator()(const facebook::react::jsinspector_modern::UniqueMonostate<key>&) const noexcept;
}
}
Loading