Guard LogBox dialog dismiss against detached window#56765
Open
aroravarun wants to merge 1 commit into
Open
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@aroravarun has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104391294. |
Summary: `LogBoxDialogSurfaceDelegate.hide()` calls `dialog.dismiss()` whenever `dialog.isShowing` is true, but the host Activity's window can be torn down between the dispatch of `LogBoxModule.hide()` and the Handler callback that runs `hide()`. When that race hits, `Dialog.dismiss()` routes to `WindowManagerImpl.removeViewImmediate`, which throws `IllegalArgumentException: View ... not attached to window manager` and crashes the process. Add an `isAttachedToWindow` check on the dialog's DecorView so the dismiss is skipped once the host window is gone. The dialog reference is still nulled and `destroyContentView()` still runs, so React state is cleaned up correctly. Changelog: [Android][Fixed] - Avoid IllegalArgumentException when LogBox dismisses after the host Activity is destroyed Differential Revision: D104391294
aroravarun
force-pushed
the
export-D104391294
branch
from
16c561c to
7efe1c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
LogBoxDialogSurfaceDelegate.hide()callsdialog.dismiss()wheneverdialog.isShowingis true, but the host Activity's window can be torndown between the dispatch of
LogBoxModule.hide()and the Handlercallback that runs
hide(). When that race hits,Dialog.dismiss()routes to
WindowManagerImpl.removeViewImmediate, which throwsIllegalArgumentException: View ... not attached to window managerand crashes the process.
Add an
isAttachedToWindowcheck on the dialog's DecorView so thedismiss is skipped once the host window is gone. The dialog reference
is still nulled and
destroyContentView()still runs, so React stateis cleaned up correctly.
Changelog:
[Android][Fixed] - Avoid IllegalArgumentException when LogBox dismisses after the host Activity is destroyed
Differential Revision: D104391294