Update file paths to use rootProject reference#55992
Update file paths to use rootProject reference#55992etodanik wants to merge 1 commit intofacebook:mainfrom
Conversation
A recent commit created a regression in what can be done with `build.gradle.kts` by what looks like non intentional usage of File() over rootProject.file(). It is very useful for out-of-tree platforms (such as my react native for unreal engine) to be able to wrap this build gradle file, and using File() breaks things because it breaks lookup in that use case. This PR fixes this unintentional regression by using `rootProject.file`, as it is used elsewhere in this file.
|
Hi @etodanik! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
@j-piasecki maybe you could take a look at it? Since it references your commit directly |
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this in D95823119. |
Summary:
A recent commit created a regression in what can be done with
build.gradle.ktsby what looks like non intentional usage of File() over rootProject.file().It is very useful for out-of-tree platforms (such as my react native for unreal engine) to be able to wrap this build gradle file, and using File() breaks things because it breaks lookup in that use case.
This PR fixes this unintentional regression by using
rootProject.file, as it is used elsewhere in this file.Changelog:
Changed
File()torootProject.file()in lines introduced by new commit (076e6a1)Pick one each for the category and type tags:
[GENERAL] [FIXED] - Fix build regression by using rootProject.file
Test Plan:
Build project as usual.