Skip to content

Update file paths to use rootProject reference#55992

Open
etodanik wants to merge 1 commit intofacebook:mainfrom
etodanik:fix-build-gradle-regression
Open

Update file paths to use rootProject reference#55992
etodanik wants to merge 1 commit intofacebook:mainfrom
etodanik:fix-build-gradle-regression

Conversation

@etodanik
Copy link

@etodanik etodanik commented Mar 8, 2026

Summary:

A recent commit created a regression in what can be done with build.gradle.kts by what looks like non intentional usage of File() over rootProject.file().

It is very useful for out-of-tree platforms (such as my react native for unreal engine) to be able to wrap this build gradle file, and using File() breaks things because it breaks lookup in that use case.

This PR fixes this unintentional regression by using rootProject.file, as it is used elsewhere in this file.

Changelog:

Changed File() to rootProject.file() in lines introduced by new commit (076e6a1)

Pick one each for the category and type tags:

[GENERAL] [FIXED] - Fix build regression by using rootProject.file

Test Plan:

Build project as usual.

A recent commit created a regression in what can be done with `build.gradle.kts` by what looks like non intentional usage of File() over rootProject.file(). 

It is very useful for out-of-tree platforms (such as my react native for unreal engine) to be able to wrap this build gradle file, and using File() breaks things because it breaks lookup in that use case.

This PR fixes this unintentional regression by using `rootProject.file`, as it is used elsewhere in this file.
@meta-cla
Copy link

meta-cla bot commented Mar 8, 2026

Hi @etodanik!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 8, 2026
@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Mar 8, 2026
@etodanik
Copy link
Author

etodanik commented Mar 8, 2026

@j-piasecki maybe you could take a look at it? Since it references your commit directly

@meta-codesync
Copy link

meta-codesync bot commented Mar 9, 2026

@cortinico has imported this pull request. If you are a Meta employee, you can view this in D95823119.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants