Remove incorrect qualification from function parameters#55971
Closed
j-piasecki wants to merge 2 commits intofacebook:mainfrom
Closed
Remove incorrect qualification from function parameters#55971j-piasecki wants to merge 2 commits intofacebook:mainfrom
j-piasecki wants to merge 2 commits intofacebook:mainfrom
Conversation
Summary: Changelog: [Internal] Adds support for identifier qualification when using template specializations and when inheriting from template objects. Reviewed By: cortinico Differential Revision: D95367957
Summary: Changelog: [Internal] Doxygen incorrectly transforms parameter names to references if they match a member. This diff strips the resulting invalid qualification from the type. Differential Revision: D95548542
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D95548542. |
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
added
p: Software Mansion
|
This pull request has been merged in 41a1941. |
Collaborator
|
This pull request was successfully merged by @j-piasecki in 41a1941 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Doxygen incorrectly transforms parameter names to references if they match a member. This diff strips the resulting invalid qualification from the type.
Differential Revision: D95548542