Update ruby version to support 3.4 Lambda runtime#523
Update ruby version to support 3.4 Lambda runtime#523YasserBennani wants to merge 2 commits intomainfrom
Conversation
YasserBennani
force-pushed
the
update-ruby-3.4
branch
2 times, most recently
from
7e7d058 to
7b84b9e
Compare
mise.toml
Outdated
| @@ -0,0 +1,3 @@ | |||
| [tools] | |||
| 1password = "latest" | |||
mise.toml
Outdated
| @@ -0,0 +1,3 @@ | |||
| [tools] | |||
| 1password = "latest" | |||
| ruby = "3.4.8" | |||
There was a problem hiding this comment.
In fact, I wonder if we should avoid adding the mise.toml file althogether? Looks like mise supports reading the ruby version from the .ruby-version file: https://mise.jdx.dev/lang/ruby.html#ruby-version-and-gemfile-support
Just conscious that adding mise.toml would mean yet another place that would need to be updated with every version change!
There was a problem hiding this comment.
Yeah, it's not strictly necessary
|
Looks good overall! Is it worth adding a note about what steps we took to test these changes? I'm thinking it would be a useful reference for ourselves for the future. I had a look at what non-Data Platform repos use
What are your thoughts on communicating these changes to the owning teams? Is it worth putting some messaging out in addition to the release description? |
Update poetry version to 2.2.1 mnatching version currently used on python repos
YasserBennani
force-pushed
the
update-ruby-3.4
branch
from
5e51f2a to
807f1b2
Compare
|
Worth communicating to owners of the other repos 👍 |
|
2 participants
serverless-toolsif still on Ruby 3.2.