fix: preserve request start time across multiple morgan instances#345
Open
SAY-5 wants to merge 1 commit into
Open
fix: preserve request start time across multiple morgan instances#345SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
When multiple morgan instances are used as middleware, each one was resetting req._startAt and res._startAt to undefined before recording a new start time. This caused all instances to measure response time from the point the last instance ran, not from the actual request start. Now the start time is only recorded once per request/response pair. Subsequent morgan instances reuse the original timestamps, so all loggers report accurate response times. Fixes expressjs#141
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When multiple morgan middleware instances are chained together, the second
one resets req._startAt and res._startAt before recording new values. This
means all instances end up measuring response time from when the last morgan
middleware ran, not from the actual request arrival.
The fix only records start timestamps once per request/response pair. If
_startAt is already set (by an earlier morgan instance), it is left alone.
Before (two morgan instances with a 100ms delay between them):
After:
Both loggers now correctly report the full response time from request start.
Includes a test that chains two morgan instances with a 50ms delay and
verifies both report times >= the delay.
Fixes #141