fix(miners): use node(s) label in PR score breakdown stat chips#1237
Open
galuis116 wants to merge 2 commits into
Open
fix(miners): use node(s) label in PR score breakdown stat chips#1237galuis116 wants to merge 2 commits into
galuis116 wants to merge 2 commits into
Conversation
Resolve conflict by moving node(s) stat chip fix to MinerPrScoreDetail after MinerScoreBreakdown was removed on test.
galuis116
force-pushed
the
fix/node-pluralization
branch
from
b70f159 to
9216d12
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On miner details, the per-PR score breakdown showed {n} nodes, which reads incorrectly for a single node (e.g. “1 nodes”).
Updates the nodes stat chip in MinerScoreBreakdown.tsx to {n} node(s) (e.g. “1 node(s)”, “2 node(s)”).
Related Issues
Fixes #1236
Type of Change
Screenshots
Checklist
npm run formatandnpm run lint:fixhave been runnpm run buildpasses