Skip to content

WT-13574: Remove WTableView header left margin & padding#241

Open
m-seibt wants to merge 3 commits intoemweb:masterfrom
m-seibt:fix/wtableview_header
Open

WT-13574: Remove WTableView header left margin & padding#241
m-seibt wants to merge 3 commits intoemweb:masterfrom
m-seibt:fix/wtableview_header

Conversation

@m-seibt
Copy link

@m-seibt m-seibt commented Mar 11, 2026

  • Factor out WTableView::columnWidthWithPadding in order to use magic number in one place
  • WTableView header cells:
    • Remove 6px margin-left and reduce padding-left in order to align with content cells
    • Adapt JS function resizeColumn and WTableView::columnWidthWithPadding
  • Round WTableView::setColumnWidth argument width to pixels instead of to whole units
screenshots without sorting with sorting
before grafik grafik
after grafik grafik

Resolves https://redmine.emweb.be/issues/13574

@RomainMard
Copy link

RomainMard commented Mar 17, 2026

Thanks for the pull request.

We already had a fix for this issue but it is indeed better to completely remove the margin here so I have adapted it to the changes you made.

As a side note, changes to Bootstrap 5 theme should be done in the src/themes/bootstrap/5/wt folder. This is what is used to compile Bootstrap 5 for Wt. How to compile Bootstrap 5 for Wt is described in doc/development/themes.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants