Skip to content

Remove unused LLDB_ENABLE_LIBEDIT, LLVM_ENABLE_TERMINFO and PYTHON_EXECUTABLE llvm configure options#1519

Closed
mcbarton wants to merge 2 commits intoemscripten-core:mainfrom
mcbarton:Remove-unused-options-llvm-build
Closed

Remove unused LLDB_ENABLE_LIBEDIT, LLVM_ENABLE_TERMINFO and PYTHON_EXECUTABLE llvm configure options#1519
mcbarton wants to merge 2 commits intoemscripten-core:mainfrom
mcbarton:Remove-unused-options-llvm-build

Conversation

@mcbarton
Copy link
Copy Markdown

@mcbarton mcbarton commented Feb 3, 2025

If you run

./emsdk install llvm-git-main-64bit

you get the following configure warnings

CMake Warning:
  Manually-specified variables were not used by the project:

    LLDB_ENABLE_LIBEDIT
    LLVM_ENABLE_TERMINFO
    PYTHON_EXECUTABLE

Therefore these options are note being used anymore in the llvm build and can be removed.

@sbc100
Copy link
Copy Markdown
Collaborator

sbc100 commented Feb 3, 2025

It could be that these are needed when building older versions of LLVM? @juj?

@mcbarton
Copy link
Copy Markdown
Author

@juj pinging for review

@mcbarton mcbarton closed this Apr 26, 2026
@sbc100
Copy link
Copy Markdown
Collaborator

sbc100 commented Apr 26, 2026

@juj?

@juj
Copy link
Copy Markdown
Collaborator

juj commented Apr 26, 2026

Sorry, this fell through my queue in the past.

When I run CMake configure on

I don't see CMake printing messages in those logs about those variables going unused.

LLDB_ENABLE_LIBEDIT cmdline config variable still exists here: https://github.com/llvm/llvm-project/blob/fbac55b82be9bf849d8a9c2514c01cb24a2a264f/lldb/cmake/modules/LLDBConfig.cmake#L60

and PYTHON_EXECUTABLE config variable still exists here: https://github.com/llvm/llvm-project/blob/fbac55b82be9bf849d8a9c2514c01cb24a2a264f/llvm/cmake/modules/CrossCompile.cmake#L86-L88

LLVM_ENABLE_TERMINFO might be unused, that I couldn't find in the LLVM repo anymore. That I think we could clean out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants