Remove unused LLDB_ENABLE_LIBEDIT, LLVM_ENABLE_TERMINFO and PYTHON_EXECUTABLE llvm configure options#1519
Conversation
…ECUTABLE llvm configure options
|
It could be that these are needed when building older versions of LLVM? @juj? |
|
@juj pinging for review |
|
@juj? |
|
Sorry, this fell through my queue in the past. When I run CMake configure on
I don't see CMake printing messages in those logs about those variables going unused. LLDB_ENABLE_LIBEDIT cmdline config variable still exists here: https://github.com/llvm/llvm-project/blob/fbac55b82be9bf849d8a9c2514c01cb24a2a264f/lldb/cmake/modules/LLDBConfig.cmake#L60 and PYTHON_EXECUTABLE config variable still exists here: https://github.com/llvm/llvm-project/blob/fbac55b82be9bf849d8a9c2514c01cb24a2a264f/llvm/cmake/modules/CrossCompile.cmake#L86-L88 LLVM_ENABLE_TERMINFO might be unused, that I couldn't find in the LLVM repo anymore. That I think we could clean out. |
If you run
you get the following configure warnings
Therefore these options are note being used anymore in the llvm build and can be removed.